Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error handling consistent across all packages #104

Closed
2 tasks
xmudrii opened this issue Oct 10, 2018 · 8 comments
Closed
2 tasks

Make error handling consistent across all packages #104

xmudrii opened this issue Oct 10, 2018 · 8 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@xmudrii
Copy link
Member

xmudrii commented Oct 10, 2018

User story

In #87 the error handling got improved for some packages. We should check other packages and make sure the error checking and handling is consistent across all packages.

We could research is it possible to overall improve logging and error handling. For ideas, we can see how other providers handle this.

Acceptance criteria

  • Make error handling consistent across all packages
  • Potentially, find a better way for error handling and logging
@xmudrii xmudrii added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 10, 2018
@xmudrii xmudrii added this to the v1beta1 milestone Oct 10, 2018
@xmudrii xmudrii added kind/bug Categorizes issue or PR as related to a bug. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 10, 2018
@nikhita
Copy link
Member

nikhita commented Oct 15, 2018

Created #109 to make the error handling consistent across the project.

Re logging: we use glog currently but there has been discussion about how glog might not be a good choice for logging - kubernetes/kubernetes#61006.

Fwiw, with respects to the project moving upstream, Kubernetes itself uses glog right now and it doesn't look like it is going to move away from it soon.

@solidnerd
Copy link
Contributor

Are there any updates regarding the logging topic ?

It seems that a lot of upstream projects use klog right now. This is a kubernetes fork of glog .

@xmudrii
Copy link
Member Author

xmudrii commented Jan 10, 2019

@solidnerd Moving to klog would be very useful and my plan is to do it once #126 is merged.

If you'd like to take on it as well, let us know. I would just recommend waiting for #126 or working based on that branch, as there are some packages that are added and removed.

@solidnerd
Copy link
Contributor

@xmudrii I can take it and work from #126 as base. After the merge we can rebase it.

@xmudrii
Copy link
Member Author

xmudrii commented Jan 10, 2019

@solidnerd Sounds good, thanks! :)

@solidnerd
Copy link
Contributor

@xmudrii what is missing here to bring this issue over the line ?

@xmudrii
Copy link
Member Author

xmudrii commented Mar 17, 2019

@solidnerd I think it's okay to close this issue. Thanks for the help!

/close

@k8s-ci-robot
Copy link

@xmudrii: Closing this issue.

In response to this:

@solidnerd I think it's okay to close this issue. Thanks for the help!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants