-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Domain ID instead of path while resolving User #322
Use Domain ID instead of path while resolving User #322
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @vignesh-goutham. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
lgtm Is this difficult to test through unit tests? |
/approve |
Yea, unit test for the changes in this PR doesnt provide us much. But for the proper change to fix domain resolution using names, we can expect unit tests to capture and test different domains with different leveled paths. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisdoherty4, rohityadavcloud, vignesh-goutham The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/cherry-pick release-0.4 |
/cherrypick release-0.4 |
Issue #, if available: Does not fix but alleviates #321 in few code paths.
Description of changes:
The ListUsers API only returns a domain ID and a domain name pertaining to the user provided as input. Using domain name in place of domain path, leads to assuming the parent domain here is
ROOT
. Instead this change, sets the domain id which is more deterministic and leads to clear identification and resolution of domain.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.