-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Decrease network interruption time for toxiproxy test #276
e2e: Decrease network interruption time for toxiproxy test #276
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @vishesh92. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vishesh92, weizhouapache The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-e2e -c 4.18 |
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
|
Test Results : (tid-124)
|
/run-e2e -c 4.18 -i rockylinux-8-kube |
@weizhouapache a jenkins job has been kicked to run test with following paramaters:
|
Test Results : (tid-125)
|
/lgtm |
Issue #, if available:
Description of changes:
As of now, e2e tests for ToxiProxy fail intermittently. Because sometimes due to network interruption, it takes some extra time for different resources to become available. Decreasing the time for network interruption fixes that.
Testing performed:
I tested two changes:
With both the changes, the tests were always passing. I ran a couple of tests with these changes separately and tests were always passing. I am decreasing the interruption, since increasing the wait time also increased the duration of the tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.