Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: fix disk_offering_test.go #247

Merged
merged 1 commit into from
May 23, 2023
Merged

e2e: fix disk_offering_test.go #247

merged 1 commit into from
May 23, 2023

Conversation

weizhouapache
Copy link
Collaborator

Issue #, if available:

Description of changes:

Got the following error when run e2e test /test/e2e/disk_offering.go

    • [FAILED] [292.946 seconds]
    When testing with disk offering [It] Should successfully create a cluster with disk offering
    /data/git/cluster-api-provider-cloudstack/test/e2e/disk_offering.go:60

    [FAILED] Expected
        <string>:
    to equal
        <string>: Small
    In [It] at: /data/git/cluster-api-provider-cloudstack/test/e2e/common.go:515

The error is because diskofferingname of VM is not the offering name of DATA disks. It is the offering name of ROOT disk only when the VM is created from ISO.

The test passes if check the offering name of DATA disks instead.

Testing performed:

Ran 2 of 29 Specs in 722.485 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 27 Skipped
PASS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@weizhouapache
test/e2e/common.go: fix disk_offering_test.go
3884bf4 
    • [FAILED] [292.946 seconds]
    When testing with disk offering [It] Should successfully create a cluster with disk offering
    /data/git/cluster-api-provider-cloudstack/test/e2e/disk_offering.go:60

    [FAILED] Expected
        <string>:
    to equal
        <string>: Small
    In [It] at: /data/git/cluster-api-provider-cloudstack/test/e2e/common.go:515

The error is because diskofferingname of VM is not the offering name of DATA disks.
It is the offering name of ROOT disk only when the VM is created from ISO.

The test passes if check the offering name of DATA disks instead.
@k8s-ci-robot k8s-ci-robot requested review from dims and jweite-amazon May 9, 2023 09:48
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2023
@netlify
Copy link

netlify bot commented May 9, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
🔨 Latest commit 3884bf4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/645a16d3a763ba0008743d74
😎 Deploy Preview https://deploy-preview-247--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

Hi @weizhouapache. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2023
@weizhouapache weizhouapache changed the title test/e2e/common.go: fix disk_offering_test.go e2e: fix disk_offering_test.go May 9, 2023
@weizhouapache
Copy link
Collaborator Author

/run-e2e help

@weizhouapache weizhouapache mentioned this pull request May 23, 2023
Closed
9 tasks
@rohityadavcloud
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2023
@rohityadavcloud
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohityadavcloud, weizhouapache

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@rohityadavcloud
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 072e1dc into kubernetes-sigs:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@jweite-amazon jweite-amazon Awaiting requested review from jweite-amazon

Assignees

@rohityadavcloud rohityadavcloud

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weizhouapache @k8s-ci-robot @rohityadavcloud