-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update multiple dependencies to latest version #233
Conversation
Run a couple scanners and updated a few modules.
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
=======================================
Coverage 33.96% 33.96%
=======================================
Files 43 43
Lines 3901 3901
=======================================
Hits 1325 1325
Misses 2394 2394
Partials 182 182 ☔ View full report in Codecov by Sentry. |
@rohityadavcloud @davidjumani |
Currently e2e tests are broken that we'll try to fix, this was due to some dependency changes. We can help kick tests once that is fixed. cc @davidjumani @weizhouapache @vishesh92 |
I'm not seeing any updates that would prove problematic. I think it might be a good idea to proceed with merging this without the E2E. |
I would leave upto your discretion then @chrisdoherty4 thnx |
/lgtm @rohityadavcloud I don't have perms currently so you'll need to add your approval. |
@chrisdoherty4: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I’ll help but cc @vishesh92 @weizhouapache @davidjumani we need to fix e2e tests |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston, rohityadavcloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Run a couple scanners and updated a few modules.
Issue #, if available:
Description of changes:
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.