Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiple dependencies to latest version #233

Merged
merged 1 commit into from
May 4, 2023

Conversation

g-gaston
Copy link
Contributor

@g-gaston g-gaston commented May 2, 2023

Run a couple scanners and updated a few modules.

Issue #, if available:

Description of changes:

Testing performed:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Run a couple scanners and updated a few modules.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2023
@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
🔨 Latest commit 2f5f087
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/64515fd79fd5d000086d5009
😎 Deploy Preview https://deploy-preview-233--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot requested review from davidjumani and dims May 2, 2023 19:09
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (1ae418d) 33.96% compared to head (2f5f087) 33.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   33.96%   33.96%           
=======================================
  Files          43       43           
  Lines        3901     3901           
=======================================
  Hits         1325     1325           
  Misses       2394     2394           
  Partials      182      182           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@g-gaston
Copy link
Contributor Author

g-gaston commented May 2, 2023

@rohityadavcloud @davidjumani
any chance we can run this through to CI to ensure there are no regressions?

@rohityadavcloud
Copy link
Member

Currently e2e tests are broken that we'll try to fix, this was due to some dependency changes. We can help kick tests once that is fixed. cc @davidjumani @weizhouapache @vishesh92

@chrisdoherty4
Copy link
Member

I'm not seeing any updates that would prove problematic. I think it might be a good idea to proceed with merging this without the E2E.

@rohityadavcloud
Copy link
Member

rohityadavcloud commented May 3, 2023

I would leave upto your discretion then @chrisdoherty4 thnx

@chrisdoherty4
Copy link
Member

/lgtm

@rohityadavcloud I don't have perms currently so you'll need to add your approval.

@k8s-ci-robot
Copy link
Contributor

@chrisdoherty4: changing LGTM is restricted to collaborators

In response to this:

/lgtm

@rohityadavcloud I don't have perms currently so you'll need to add your approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rohityadavcloud
Copy link
Member

I’ll help but cc @vishesh92 @weizhouapache @davidjumani we need to fix e2e tests
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston, rohityadavcloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [g-gaston,rohityadavcloud]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants