Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading cluster-api dependency to support k8s v1.24 #189

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Nov 9, 2022

Upgrades dependencies to support Kubernetes v1.24
Ref : https://github.com/kubernetes-sigs/cluster-api/releases/tag/v1.2.2

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 9, 2022
@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
🔨 Latest commit 0bf4596
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/6395f5ef180039000947488b
😎 Deploy Preview https://deploy-preview-189--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidjumani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidjumani
Copy link
Contributor Author

/run-e2e

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2022
@blueorangutan
Copy link

A job created for running /run-e2e, will keep you posted when the result is ready

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 9, 2022
@blueorangutan
Copy link

Setting up environment failed

@blueorangutan
Copy link

E2E Test Run Logs: https://github.com/pearl1594/test-upload-assets/releases/download/tag1/artifacts-25.zip
Test Result:

FAIL! -- 0 Passed | 12 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (207.98s)
FAIL

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2022
@davidjumani davidjumani force-pushed the support-k8-1.24 branch 3 times, most recently from 9e9eae5 to b82507c Compare December 11, 2022 14:52
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2022
@davidjumani davidjumani marked this pull request as ready for review December 11, 2022 15:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2022
@kubernetes-sigs kubernetes-sigs deleted a comment from blueorangutan Dec 11, 2022
@kubernetes-sigs kubernetes-sigs deleted a comment from blueorangutan Dec 11, 2022
@kubernetes-sigs kubernetes-sigs deleted a comment from blueorangutan Dec 11, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 34.04% // Head: 34.04% // No change to project coverage 👍

Coverage data is based on head (0bf4596) compared to base (fc149db).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   34.04%   34.04%           
=======================================
  Files          43       43           
  Lines        3892     3892           
=======================================
  Hits         1325     1325           
  Misses       2387     2387           
  Partials      180      180           
Impacted Files Coverage Δ
api/v1beta1/cloudstackcluster_types.go 25.00% <ø> (ø)
api/v1beta1/cloudstackzone_types.go 100.00% <ø> (ø)
api/v1beta2/cloudstackmachinetemplate_webhook.go 66.66% <ø> (ø)
pkg/cloud/instance.go 79.59% <75.00%> (ø)
controllers/cloudstackcluster_controller.go 20.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blueorangutan
Copy link

Failed to run e2e test

@blueorangutan
Copy link

Setting up environment failed

@blueorangutan
Copy link

Test Results : (tid-40)
Environment: kvm(x3), Advanced Networking with Management Server Centos 7
Kubernetes Version v1.24.7
E2E Test Run Logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/capc-e2e-artifacts-40.zip

[PASS] When testing machine remediation Should replace a machine when it is destroyed
[PASS] When testing horizontal scale out/in [TC17][TC18][TC20][TC21] Should successfully scale machine replicas up and down horizontally
[PASS] When testing with disk offering Should successfully create a cluster with disk offering
[PASS] When testing affinity group Should have host affinity group when affinity is anti
[PASS] When testing MachineDeployment rolling upgrades Should successfully upgrade Machines upon changes in relevant MachineDeployment fields
[PASS] When testing with custom disk offering Should successfully create a cluster with a custom disk offering
[PASS] When testing app deployment to the workload cluster [TC1][PR-Blocking] Should be able to download an HTML from the app deployed to the workload cluster
[PASS] When testing app deployment to the workload cluster with slow network [ToxiProxy] Should be able to download an HTML from the app deployed to the workload cluster
[PASS] with two clusters should successfully add and remove a second cluster without breaking the first cluster
[PASS] When testing node drain timeout A node should be forcefully removed if it cannot be drained in time
[PASS] When testing resource cleanup Should create a new network when the specified network does not exist


Summarizing 1 Failure:

[Fail] When testing affinity group [It] Should have host affinity group when affinity is pro 
/root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/controlplane_helpers.go:116

Ran 12 of 12 Specs in 6243.016 seconds
FAIL! -- 11 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (6243.02s)
FAIL

@rohityadavcloud
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@davidjumani davidjumani merged commit c00943a into main Dec 12, 2022
vignesh-goutham pushed a commit to vignesh-goutham/cluster-api-provider-cloudstack that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants