Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for FIPS #760

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Added support for FIPS #760

merged 1 commit into from
Sep 6, 2022

Conversation

dima618
Copy link
Contributor

@dima618 dima618 commented Aug 22, 2022 •
edited
Loading

Feature

What is this PR about? / Why do we need it?
Added support for configuring the efs-csi-driver to use FIPS when mounting file systems.

What testing is done?
Manual testing: https://quip-amazon.com/ODxXAOdSxTpb/efs-csi-driverefs-utils-FIPS-Testing-Design#temp:C:aMH7252de3f2d0446938cc776ddf

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 22, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dima618. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 22, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2022
@Ashley-wenyizha
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2022
@dima618
Copy link
Contributor Author

dima618 commented Aug 30, 2022

/retest

1 similar comment
@Ashley-wenyizha
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2022
@dima618
Copy link
Contributor Author

dima618 commented Aug 30, 2022

Ran go mod vendor

wongma7
wongma7 reviewed Sep 6, 2022
View reviewed changes
pkg/cloud/cloud.go
@@ -133,9 +133,12 @@ func createCloud(awsRoleArn string) (Cloud, error) {
return nil, fmt.Errorf("could not get metadata: %v", err)
}

efs_client := createEfsClient(awsRoleArn, metadata, sess)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer camelCase for names in golang

@wongma7
Copy link
Contributor

wongma7 commented Sep 6, 2022

/approve

thank you

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dima618, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@wongma7
Copy link
Contributor

wongma7 commented Sep 6, 2022

will let @Ashley-wenyizha do final review and drop the '/lgtm'

@Ashley-wenyizha
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5648677 into kubernetes-sigs:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 wongma7 left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees

@Ashley-wenyizha Ashley-wenyizha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dima618 @k8s-ci-robot @Ashley-wenyizha @wongma7