Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/text/language for CVE-2021-38561 #738

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

RomanBednar
Copy link
Contributor

Is this a bug fix or adding new feature?
Bug fix.

What is this PR about? / Why do we need it?
Due to improper index calculation, an incorrectly formatted language tag can cause Parse to panic via an out of bounds read. If Parse is used to process untrusted user inputs, this may be used as a vector for a denial of service attack.

Source: https://deps.dev/advisory/OSV/GO-2021-0113

Updated using following commands:

go mod why -m golang.org/x/text
go get -u k8s.io/client-go/rest golang.org/x/net/http2 golang.org/x/net/idna golang.org/x/text/secure/bidirule
go mod tidy && go mod vendor

What testing is done?
No manual testing required.

Due to improper index calculation, an incorrectly formatted language
tag can cause Parse to panic via an out of bounds read. If Parse is
used to process untrusted user inputs, this may be used as a vector for
a denial of service attack.

Source: https://deps.dev/advisory/OSV/GO-2021-0113

Updated using following commands:

go mod why -m golang.org/x/text
go get -u k8s.io/client-go/rest golang.org/x/net/http2 golang.org/x/net/idna golang.org/x/text/secure/bidirule
go mod tidy && go mod vendor
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 15, 2022
@RomanBednar
Copy link
Contributor Author

/assign @wongma7

@jsafrane
Copy link
Contributor

jsafrane commented Aug 4, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit 390fcae into kubernetes-sigs:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants