-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helm config to enable deleteAccessPointRootDir #412
feat: add helm config to enable deleteAccessPointRootDir #412
Conversation
Welcome @KarstenSiemer! |
Hi @KarstenSiemer. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @leakingtapan |
/ok-to-test |
274be81
to
e4bf8ba
Compare
lessened coverage makes sense in this case. But do we want to write tests for the helm chart? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KarstenSiemer, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@KarstenSiemer don't worry about ocveralls, it's bugged sometimes, I will merge once the other Required tests pass. |
Is this a bug fix or adding new feature?
This is a new feature. (Also includes very minor fix for the log level in the controller deployment for the log level)
What is this PR about? / Why do we need it?
It adds the ability to enable the --delete-access-point-root-dir flag on the controller deployments efs-plugin sidecar.
What testing is done?
Talked about the flag in #411
I'd suggest to use it like this in helm. If the value is set to false or is omitted, then the flag will be set to false. If the value is set to true, then it will be set to true. This way we don't have to change the chart again, if the default behavior of the flag will be changed, like if it would default to true.
Merged this pr in my fork and rolled it out in a cluster.