Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix helm chart external-provisioner RBAC not being created if serviceaccount.controller.create false & pick up master branch fixes #377

Merged
merged 10 commits into from
Mar 23, 2021
Merged

Fix helm chart external-provisioner RBAC not being created if serviceaccount.controller.create false & pick up master branch fixes #377

merged 10 commits into from
Mar 23, 2021

Conversation

kbasv
Copy link

@kbasv kbasv commented Mar 21, 2021

Is this a bug fix or adding new feature?
Helm chart update for release 1.2

What is this PR about? / Why do we need it?

What testing is done?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 21, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @kbasv. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2021
jqmichael
jqmichael reviewed Mar 22, 2021
View reviewed changes
.github/workflows/release.yaml
Comment on lines -14 to -16
- name: Create Helm chart
run: |
tar cvzf helm-chart.tgz helm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we delete this because it was never being used?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ported this from master branch. I think @wongma7 has more context on this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matthew Wong
we have a separate github action just for releasing the helm chart, and we moved the location of the helm chart, so that one was broken. and yes, the tgz is kind of useless since we recommend using helm repo approach

@jqmichael
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2021
@jqmichael
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2021
@wongma7
Copy link
Contributor

wongma7 commented Mar 22, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbasv, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2021
@wongma7
Copy link
Contributor

wongma7 commented Mar 22, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2021
@kbasv
Copy link
Author

kbasv commented Mar 22, 2021

/retest

1 similar comment
@kbasv
Copy link
Author

kbasv commented Mar 22, 2021

/retest

@kbasv
Copy link
Author

kbasv commented Mar 22, 2021

/restart

1 similar comment
@kbasv
Copy link
Author

kbasv commented Mar 22, 2021

/restart

@kbasv
Copy link
Author

kbasv commented Mar 22, 2021

/test pull-aws-efs-csi-driver-e2e

2 similar comments
@kbasv
Copy link
Author

kbasv commented Mar 22, 2021

/test pull-aws-efs-csi-driver-e2e

@kbasv
Copy link
Author

kbasv commented Mar 22, 2021

/test pull-aws-efs-csi-driver-e2e

@wongma7
Copy link
Contributor

wongma7 commented Mar 22, 2021

@kbasv can you also include #383 .

I also reproduced the error locally.

@wongma7
Copy link
Contributor

wongma7 commented Mar 22, 2021

/test pull-aws-efs-csi-driver-e2e

@wongma7 wongma7 added this to the 1.2 milestone Mar 22, 2021
@kbasv
Copy link
Author

kbasv commented Mar 23, 2021

/test pull-aws-efs-csi-driver-e2e

@k8s-ci-robot k8s-ci-robot merged commit 29c3a7b into kubernetes-sigs:release-1.2 Mar 23, 2021
@wongma7 wongma7 mentioned this pull request Mar 23, 2021
Merged
@wongma7 wongma7 changed the title Release 1.2 Fix helm chart & pick up master branch fixes Mar 23, 2021
@wongma7 wongma7 changed the title Fix helm chart & pick up master branch fixes Fix helm chart external-provisioner RBAC not being created if serviceaccount.controller.create false & pick up master branch fixes Mar 23, 2021
@kbasv kbasv mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jqmichael jqmichael jqmichael left review comments

@wongma7 wongma7 wongma7 left review comments

Assignees

@wongma7 wongma7

@jqmichael jqmichael

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@kbasv @k8s-ci-robot @jqmichael @wongma7