Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation and examples for dynamic provisioning #297

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Add documentation and examples for dynamic provisioning #297

merged 1 commit into from
Mar 12, 2021

Conversation

kbasv
Copy link

@kbasv kbasv commented Jan 8, 2021 •
edited
Loading

Is this a bug fix or adding new feature?
Documentation update for #274

What is this PR about? / Why do we need it?
Add documentation and provide an example for dynamic provisioning

What testing is done?
N/A

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @kbasv. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2021
@kbasv
Copy link
Author

kbasv commented Jan 8, 2021

@wongma7 Updated documentation and provided example for #274, please have a look. Thanks!

@kbasv
Copy link
Author

kbasv commented Jan 8, 2021

/assign @wongma7

@wongma7
Copy link
Contributor

wongma7 commented Jan 11, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2021
wongma7
wongma7 reviewed Jan 11, 2021
View reviewed changes
docs/README.md
@@ -19,9 +19,24 @@ The [Amazon Elastic File System](https://aws.amazon.com/efs/) Container Storage
Currently only static provisioning is supported. This means an AWS EFS file system needs to be created manually on AWS first. After that it can be mounted inside a container as a volume using the driver.

The following CSI interfaces are implemented:
* Controller Service: CreateVolume, DeleteVolume, ControllerGetCapabilities, ValidateVolumeCapabilities
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a (temporary) note that you need a prerelase version of the driver, because I'm planning to release 1.1.0 with the bottlerocket fix and various version bumps, and then do the dynamic provisioning release in 1.2.0 or something.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will be the pre-release version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm since it doesn't exist yet, I think we can hold this PR until it does, then we will be able to provide clearer instructions for how to try it

@kbasv kbasv marked this pull request as draft January 11, 2021 21:42
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2021
wongma7
wongma7 reviewed Jan 11, 2021
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
@kbasv kbasv marked this pull request as ready for review March 8, 2021 21:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2021
@wongma7
Copy link
Contributor

wongma7 commented Mar 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2021
@wongma7
Copy link
Contributor

wongma7 commented Mar 12, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbasv, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit bea5fd4 into kubernetes-sigs:master Mar 12, 2021
@kbasv kbasv mentioned this pull request Apr 23, 2021
Closed
@kbasv kbasv deleted the controller-doc branch April 26, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamin-tucker benjamin-tucker benjamin-tucker left review comments

@jqmichael jqmichael jqmichael left review comments

@wongma7 wongma7 wongma7 left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kbasv @k8s-ci-robot @wongma7 @jqmichael @benjamin-tucker