Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Access Points: Require separate file systems #168

Merged
merged 1 commit into from
May 27, 2020
Merged

Doc: Access Points: Require separate file systems #168

merged 1 commit into from
May 27, 2020

Conversation

2uasimojo
Copy link
Contributor

Per issue #167, it turns out that you can't use separate access points to the same EFS volume from the same pod. Correct the documentation pending a fix.

Is this a bug fix or adding new feature?
Docs only.

What is this PR about? / Why do we need it?
Docs are wrong until #167 is resolved.

What testing is done?
Rendered doc. Looks peachy.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from d-nishi and nckturner May 20, 2020 21:17
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @2uasimojo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 20, 2020
@2uasimojo
Doc: Access Points: Require separate file systems
cebb906 
Per [issue kubernetes-sigs#167](kubernetes-sigs#167),
it turns out that you *can't* use separate access points to the same EFS
volume from the same pod. Correct the documentation pending a fix.
@2uasimojo 2uasimojo mentioned this pull request May 20, 2020
Closed
@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2020
@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 25, 2020
@2uasimojo
Copy link
Contributor Author

/test pull-aws-efs-csi-driver-e2e

@2uasimojo
Copy link
Contributor Author

/test pull-aws-efs-csi-driver-verify

@k8s-ci-robot k8s-ci-robot merged commit 2399930 into kubernetes-sigs:master May 27, 2020
@2uasimojo 2uasimojo mentioned this pull request Jun 18, 2020
Merged
@2uasimojo
Copy link
Contributor Author

Reverted in #185, which fixes #167.

@2uasimojo 2uasimojo deleted the issues-167 branch June 18, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@nckturner nckturner Awaiting requested review from nckturner

Assignees

@leakingtapan leakingtapan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2uasimojo @k8s-ci-robot @leakingtapan