-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for Access Points #153
Conversation
Adds a README and sample specs for exposing multiple independent data sources on the same EFS volume by creating and mounting access points.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @2uasimojo! |
Hi @2uasimojo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the iam permission
Document the additional IAM permissions needed (none, by default) to mount access points.
f935df9
to
1364304
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds a README and sample specs for exposing multiple independent data
sources on the same EFS volume by creating and mounting access points.
Is this a bug fix or adding new feature?
Neither, really. It's adding docs for a thing that already works.
What is this PR about? / Why do we need it?
There are questions about how to manage the permissions of the mounts, which by default are inaccessible because they're owned by
root:root
with 755 permissions. Changing permissions of the root export and creating subdirectories both require manual intervention by a powerful user. This provides an alternative that does not (though it does require the ability to administer EFS itself).What testing is done?
Well, this is a doc, so it's not tested per se. But I've been using the outlined procedure under OpenShift Dedicated 4.3.