Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump side-cars to the latest #1484

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

mskanth972
Copy link
Contributor

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
This PR bumps the side cars to the latest version.
This PR also fixes the issue with external proviosiner side car issue of not terminating PVs when PVCs are deleted.
https://github.com/rhrmo/external-provisioner/blob/master/CHANGELOG/CHANGELOG-5.1.md#bug-or-regression

What testing is done?

@k8s-ci-robot k8s-ci-robot requested a review from d-nishi October 25, 2024 15:01
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 25, 2024
@k8s-ci-robot k8s-ci-robot requested a review from wongma7 October 25, 2024 15:01
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mskanth972

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2024
@jrakas-dev
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jrakas-dev: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mskanth972 mskanth972 merged commit c8c3190 into kubernetes-sigs:master Oct 25, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants