Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sidecar versions to fix CVE-2023-45288 and CVE-2024-24786 #1373

Closed

Conversation

omerap12
Copy link
Member

@omerap12 omerap12 commented Jun 11, 2024

Is this a bug fix or adding new feature?
bug fix.
fixes: #1365

What is this PR about? / Why do we need it?
Mitigating CVE-2023-45288 and CVE-2024-24786

What testing is done?
Following tests:

~/Desktop/PersonlRepos/aws-efs-csi-driver/ [sidecarsversionsbump] trivy image public.ecr.aws/eks-distro/kubernetes-csi/livenessprobe:v2.13.0-eks-1-30-7
2024-06-11T09:40:26+03:00	INFO	Vulnerability scanning is enabled
2024-06-11T09:40:26+03:00	INFO	Secret scanning is enabled
2024-06-11T09:40:26+03:00	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-11T09:40:26+03:00	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-11T09:40:28+03:00	INFO	Detected OS	family="amazon" version="2 (Karoo)"
2024-06-11T09:40:28+03:00	INFO	[amazon] Detecting vulnerabilities...	os_version="2" pkg_num=6
2024-06-11T09:40:28+03:00	INFO	Number of language-specific files	num=1
2024-06-11T09:40:28+03:00	INFO	[gobinary] Detecting vulnerabilities...

public.ecr.aws/eks-distro/kubernetes-csi/livenessprobe:v2.13.0-eks-1-30-7 (amazon 2 (Karoo))

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

and

~/Desktop/PersonlRepos/aws-efs-csi-driver/ [sidecarsversionsbump] trivy image public.ecr.aws/eks-distro/kubernetes-csi/node-driver-registrar:v2.11.0-eks-1-30-7
2024-06-11T09:41:19+03:00	INFO	Vulnerability scanning is enabled
2024-06-11T09:41:19+03:00	INFO	Secret scanning is enabled
2024-06-11T09:41:19+03:00	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-11T09:41:19+03:00	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-11T09:41:22+03:00	INFO	Detected OS	family="amazon" version="2 (Karoo)"
2024-06-11T09:41:22+03:00	INFO	[amazon] Detecting vulnerabilities...	os_version="2" pkg_num=6
2024-06-11T09:41:22+03:00	INFO	Number of language-specific files	num=1
2024-06-11T09:41:22+03:00	INFO	[gobinary] Detecting vulnerabilities...

public.ecr.aws/eks-distro/kubernetes-csi/node-driver-registrar:v2.11.0-eks-1-30-7 (amazon 2 (Karoo))

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

and

~/Desktop/PersonlRepos/aws-efs-csi-driver/ [sidecarsversionsbump] trivy image public.ecr.aws/eks-distro/kubernetes-csi/external-provisioner:v4.0.1-eks-1-30-7
2024-06-11T09:42:05+03:00	INFO	Vulnerability scanning is enabled
2024-06-11T09:42:05+03:00	INFO	Secret scanning is enabled
2024-06-11T09:42:05+03:00	INFO	If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-06-11T09:42:05+03:00	INFO	Please see also https://aquasecurity.github.io/trivy/v0.52/docs/scanner/secret/#recommendation for faster secret detection
2024-06-11T09:42:07+03:00	INFO	Detected OS	family="amazon" version="2 (Karoo)"
2024-06-11T09:42:07+03:00	INFO	[amazon] Detecting vulnerabilities...	os_version="2" pkg_num=6
2024-06-11T09:42:07+03:00	INFO	Number of language-specific files	num=1
2024-06-11T09:42:07+03:00	INFO	[gobinary] Detecting vulnerabilities...

public.ecr.aws/eks-distro/kubernetes-csi/external-provisioner:v4.0.1-eks-1-30-7 (amazon 2 (Karoo))

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign wongma7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from justinsb and wongma7 June 11, 2024 06:39
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

@omerap12: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-efs-csi-driver-e2e 0c3c29a link true /test pull-aws-efs-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mskanth972
Copy link
Contributor

Hi @omerap12 the sidecar versions referenced in the PR are not yet available in the private ECR repositories, this will lead to installation issues with the private manifest. I've contacted the internal team to push these versions, and they have indicated that the expected completion date (ECD) for this will be June 19. Once these versions are released, I will be able to proceed with merging the PR.
For example, this command should list out the side car versions for the Private manifest to work.
aws ecr list-images --region ap-southeast-1 --repository-name eks/livenessprobe --registry-id 602401143452

@omerap12
Copy link
Member Author

omerap12 commented Jun 14, 2024

Hi @omerap12 the sidecar versions referenced in the PR are not yet available in the private ECR repositories, this will lead to installation issues with the private manifest. I've contacted the internal team to push these versions, and they have indicated that the expected completion date (ECD) for this will be June 19. Once these versions are released, I will be able to proceed with merging the PR. For example, this command should list out the side car versions for the Private manifest to work. aws ecr list-images --region ap-southeast-1 --repository-name eks/livenessprobe --registry-id 602401143452

got it. sure no problem, this PR can wait :)

@mskanth972
Copy link
Contributor

I raised a PR to the most recent versions which are available in both Public and Private ECR repos
#1385
Will merge today and start the release.
Thanks for the effort @omerap12

@omerap12
Copy link
Member Author

omerap12 commented Jun 25, 2024

I raised a PR to the most recent versions which are available in both Public and Private ECR repos #1385 Will merge today and start the release. Thanks for the effort @omerap12

Sure. will you be able to take a look on another PR I have raised (#1351) ?

@mskanth972
Copy link
Contributor

I raised a PR to the most recent versions which are available in both Public and Private ECR repos #1385 Will merge today and start the release. Thanks for the effort @omerap12

Sure. will you be able to take a look on another PR I have raised (#1351) ?

Sure!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omerap12 omerap12 closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump helm charts sidecars versions to resolve CVEs
3 participants