-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose env, volume, and volume mounts in helm chart for the efs controller and deamonset #1165
Expose env, volume, and volume mounts in helm chart for the efs controller and deamonset #1165
Conversation
faf5665
to
d27086b
Compare
Would love to see this get merged. It would be really useful to inject IAM configuration for non-EKS clusters. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cnmcavoy , please undo changes to the versions in charts/aws-efs-csi-driver/CHANGELOG.md and charts/aws-efs-csi-driver/Chart.yaml, as we update these values as part of our release process
d27086b
to
142a464
Compare
+1 ... this would be very helpful |
+1 , hoping this can get merged very soon. |
/remove-lifecycle stale |
Is there an ETA for this? |
This is currently a blocking issue for me - I need to use a different CA certificate bundle when talking to the AWS API in my environment. Until this feature is merged I have no way to overwrite the CA bundle in the controller pods with the updated bundle I need to use. Would it help to create an issue to track this? |
{{ ping }} |
Issue created: #1349 |
@seanzatzdev-amazon it looks like the changes requested in this PR have been made - would you mind giving this another look? Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cnmcavoy, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Is this a bug fix or adding new feature?
New Feature
What is this PR about? / Why do we need it?
Allows configuring the EFS CSI Controller and Daemonset for IRSA in helm values without relying on the IRSA webhook being installed and configured in a cluster.
What testing is done?
helm template produces the expected output.