Merge pull request #1074 from woehrl01/optional_helm_hooks

feat: allow to don't use helm hooks for CSIDriver creation
kubernetes-sigs · Sep 24, 2024 · 1e9c794 · 1e9c794
2 parents 3886bd8 + 1d5c39c
commit 1e9c794
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/charts/aws-efs-csi-driver/templates/csidriver.yaml b/charts/aws-efs-csi-driver/templates/csidriver.yaml
@@ -3,8 +3,10 @@ kind: CSIDriver
 metadata:
   name: efs.csi.aws.com
   annotations:
+    {{- if .Values.useHelmHooksForCSIDriver }}
     "helm.sh/hook": pre-install, pre-upgrade
     "helm.sh/hook-delete-policy": before-hook-creation
+    {{- end }}
     "helm.sh/resource-policy": keep
 spec:
   attachRequired: false
diff --git a/charts/aws-efs-csi-driver/values.yaml b/charts/aws-efs-csi-driver/values.yaml
@@ -114,7 +114,6 @@ controller:
   leaderElectionRenewDeadline: 10s
   leaderElectionLeaseDuration: 15s
 
-
 ## Node daemonset variables
 
 node:
@@ -154,7 +153,8 @@ node:
     #   cpu: 100m
     #   memory: 128Mi
   nodeSelector: {}
-  updateStrategy: {}
+  updateStrategy:
+    {}
     # Override default strategy (RollingUpdate) to speed up deployment.
     # This can be useful if helm timeouts are observed.
     # type: OnDelete
@@ -208,3 +208,6 @@ storageClasses: []
 #     ensureUniqueDirectory: true
 #   reclaimPolicy: Delete
 #   volumeBindingMode: Immediate
+
+# Specifies wether to use helm hooks to apply the CSI driver
+useHelmHooksForCSIDriver: true