Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Install snapshot CRDs and controller from the external-snapshotter PR #427

Closed
wants to merge 1 commit into from
Closed

WIP: Install snapshot CRDs and controller from the external-snapshotter PR #427

wants to merge 1 commit into from

Conversation

xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Nov 16, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Manually modify prow.sh to install snapshot CRDs and controller from the PR.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot
Copy link
Contributor

@xing-yang: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from msau42 and pohly November 16, 2020 15:09
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2020
@xing-yang xing-yang force-pushed the test_deploy_images branch 3 times, most recently from e958980 to 942f494 Compare November 17, 2020 02:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 17, 2020
@xing-yang xing-yang force-pushed the test_deploy_images branch 6 times, most recently from 455b415 to 9df63c5 Compare November 17, 2020 17:51
@xing-yang
Copy link
Collaborator Author

/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-19-on-kubernetes-master

@k8s-ci-robot
Copy link
Contributor

@xing-yang: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-kubernetes-csi-external-snapshotter-1-17-on-kubernetes-1-17
  • /test pull-kubernetes-csi-external-snapshotter-1-17-on-kubernetes-master
  • /test pull-kubernetes-csi-external-snapshotter-1-18-on-kubernetes-1-18
  • /test pull-kubernetes-csi-external-snapshotter-1-18-on-kubernetes-master
  • /test pull-kubernetes-csi-external-snapshotter-1-19-on-kubernetes-1-19
  • /test pull-kubernetes-csi-external-snapshotter-1-19-on-kubernetes-master
  • /test pull-kubernetes-csi-external-snapshotter-alpha-1-19-on-kubernetes-1-19
  • /test pull-kubernetes-csi-external-snapshotter-alpha-1-19-on-kubernetes-master
  • /test pull-kubernetes-csi-external-snapshotter-unit

Use /test all to run the following jobs:

  • pull-kubernetes-csi-external-snapshotter-1-17-on-kubernetes-1-17
  • pull-kubernetes-csi-external-snapshotter-1-18-on-kubernetes-1-18
  • pull-kubernetes-csi-external-snapshotter-1-19-on-kubernetes-1-19
  • pull-kubernetes-csi-external-snapshotter-unit

In response to this:

/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-19-on-kubernetes-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Collaborator Author

@pohly can you take a look of this? I modified prow.sh manually to install snapshot CRDs and controller from the PR. If this works, I'll submit a PR to csi-release-tools.

@k8s-ci-robot
Copy link
Contributor

@xing-yang: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-snapshotter-unit 3a343b5 link /test pull-kubernetes-csi-external-snapshotter-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xing-yang
Copy link
Collaborator Author

/assign @msau42

@xing-yang xing-yang changed the title WIP: Do Not Merge WIP: Install snapshot CRDs and controller from the external-snapshotter PR Nov 17, 2020
@xing-yang
Copy link
Collaborator Author

/test pull-kubernetes-csi-external-snapshotter-1-19-on-kubernetes-master

@xing-yang
Copy link
Collaborator Author

/test pull-kubernetes-csi-external-snapshotter-1-17-on-kubernetes-master

@xing-yang
Copy link
Collaborator Author

/test pull-kubernetes-csi-external-snapshotter-1-18-on-kubernetes-master

@xing-yang
Copy link
Collaborator Author

/test pull-kubernetes-csi-external-snapshotter-alpha-1-19-on-kubernetes-1-19

@xing-yang
Copy link
Collaborator Author

/test pull-kubernetes-csi-external-snapshotter-alpha-1-19-on-kubernetes-master

@xing-yang xing-yang mentioned this pull request Nov 18, 2020
Merged
@xing-yang xing-yang closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xing-yang @k8s-ci-robot @pohly @msau42