-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use mkdir -p
for creating subdir in mounted base-dir
#412
Conversation
|
Welcome @alankan-finocomp! |
Hi @alankan-finocomp. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
mkdir -p
for creating subdir in mounted base-dirmkdir -p
for creating subdir in mounted base-dir
/kind bug |
Pull Request Test Coverage Report for Build 4161914852
💛 - Coveralls |
Sorry I am new to this prow tool and a bit lost about which line of the e2e-tests failed at :( Could you help me understand it? |
the test error would be fixed by #409 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alankan-finocomp, andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andyzhangx Thank you very much for reviewing and merging this PR promptly 🙇 May I ask if there is any upcoming release including this change please? |
What type of PR is this?
/kind bug
What this PR does / why we need it:
It creates also parent directories of sub-directories under the mounted base-dir. Just like
mkdir -p
does.Which issue(s) this PR fixes:
Fixes #411
Special notes for your reviewer:
Does this PR introduce a user-facing change?: