-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NOTES.txt selector to use a valid label #365
Conversation
|
Welcome @xr09! |
Hi @xr09. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
thanks for the contribution, pls run "helm package charts/latest/csi-driver-nfs -d charts/latest/" to update tgz file |
|
@andyzhangx Done 👌 |
Pull Request Test Coverage Report for Build 2794751723
💛 - Coveralls |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, xr09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This fixes the Helm Chart NOTES.txt to use a valid label for watching the pods being started.
Special notes for your reviewer:
Before:
With valid label:
Does this PR introduce a user-facing change?: