Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NOTES.txt selector to use a valid label #365

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Fix NOTES.txt selector to use a valid label #365

merged 2 commits into from
Aug 4, 2022

Conversation

xr09
Copy link
Contributor

@xr09 xr09 commented Aug 3, 2022

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This fixes the Helm Chart NOTES.txt to use a valid label for watching the pods being started.

Special notes for your reviewer:

Before:

kubectl --namespace=kube-system get pods --selector="release=csi-driver-nfs" --watch

"Displays  Nothing..."

With valid label:

kubectl --namespace=kube-system get pods --selector="app.kubernetes.io/instance=csi-driver-nfs" --watch
NAME                                READY   STATUS    RESTARTS   AGE
csi-nfs-controller-f56b4b4b-kgb4k   3/3     Running   0          13m
csi-nfs-node-pcm6q                  3/3     Running   0          13m
csi-nfs-node-hcs6v                  3/3     Running   0          13m
csi-nfs-node-gfhcz                  3/3     Running   0          13m

Does this PR introduce a user-facing change?:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Aug 3, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 3, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xr09 / name: Manuel GP (03012d4)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @xr09!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @xr09. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 3, 2022
@andyzhangx
Copy link
Member

thanks for the contribution, pls run "helm package charts/latest/csi-driver-nfs -d charts/latest/" to update tgz file

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xr09 / name: Manuel GP (03012d4)

@xr09
Copy link
Contributor Author

xr09 commented Aug 4, 2022

@andyzhangx Done 👌

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2794751723

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.411%

Totals Coverage Status
Change from base Build 2653996621: 0.0%
Covered Lines: 610
Relevant Lines: 788

💛 - Coveralls

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2022
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, xr09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit f32538e into kubernetes-csi:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants