-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pv/pvc metadata in subDir parameter #353
feat: support pv/pvc metadata in subDir parameter #353
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0de0a20
to
0f1d499
Compare
Pull Request Test Coverage Report for Build 2523760258
💛 - Coveralls |
0f1d499
to
34d0e6d
Compare
@gnufied @jsafrane there is discussion here about the requirement, this nfs driver should have quite similar requirement as smb driver: kubernetes-csi/csi-driver-smb#503 (comment) |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: support pv/pvc metadata in subDir parameter
subDir
parameter supports following pv/pvc metadata transform${pvc.metadata.name}
${pvc.metadata.namespace}
${pv.metadata.name}
Which issue(s) this PR fixes:
Fixes #502
Requirements:
Special notes for your reviewer:
Release note: