Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pv/pvc metadata in subDir parameter #353

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support pv/pvc metadata in subDir parameter

  • subDir parameter supports following pv/pvc metadata transform

if subDir value contains following strings, it would be converted into corresponding pv/pvc name or namespace

  • ${pvc.metadata.name}
  • ${pvc.metadata.namespace}
  • ${pv.metadata.name}

Which issue(s) this PR fixes:

Fixes #502

Requirements:

Special notes for your reviewer:

Release note:

feat: support pv/pvc metadata in subDir parameter

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2022
@coveralls
Copy link

coveralls commented Jun 19, 2022

Pull Request Test Coverage Report for Build 2523760258

  • 27 of 33 (81.82%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 77.411%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nfs/controllerserver.go 13 16 81.25%
pkg/nfs/nodeserver.go 8 11 72.73%
Totals Coverage Status
Change from base Build 2490727659: 0.5%
Covered Lines: 610
Relevant Lines: 788

💛 - Coveralls

@jingxu97
Copy link

/assign @gnufied @jsafrane

@andyzhangx
Copy link
Member Author

/assign @gnufied @jsafrane

@gnufied @jsafrane there is discussion here about the requirement, this nfs driver should have quite similar requirement as smb driver: kubernetes-csi/csi-driver-smb#503 (comment)

@jsafrane
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 933455a into kubernetes-csi:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants