Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: tag large version for master builds #74

Closed
wants to merge 1 commit into from

Conversation

msau42
Copy link
Collaborator

@msau42 msau42 commented Jul 12, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
kind checks kubernetes tagged versions to figure out which config to use. For master builds, tag a large version so that kind will look for the latest config versions.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Jul 12, 2019
@k8s-ci-robot k8s-ci-robot requested review from pohly and saad-ali July 12, 2019 22:36
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2019
@msau42
Copy link
Collaborator Author

msau42 commented Jul 12, 2019

Once kubernetes/test-infra#13434 merges, we can test

pull-kubernetes-csi-csi-driver-host-path-alpha-1-15-on-kubernetes-1-15
pull-kubernetes-csi-csi-driver-host-path-alpha-1-15-on-kubernetes-master

@msau42
Copy link
Collaborator Author

msau42 commented Jul 12, 2019

/assign @pohly

@k8s-ci-robot
Copy link
Contributor

@msau42: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-csi-csi-driver-host-path-unit 3f83c2b link /test pull-kubernetes-csi-csi-driver-host-path-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@msau42
Copy link
Collaborator Author

msau42 commented Jul 15, 2019

/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-15-on-kubernetes-1-15
/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-15-on-kubernetes-master

@pohly
Copy link
Contributor

pohly commented Jul 16, 2019

PR #76 has the same change with a clean import from csi-release-tools.

@msau42
Copy link
Collaborator Author

msau42 commented Jul 16, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@msau42: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants