Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oidc provider behind proxy #2256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

oidc provider behind proxy #2256

wants to merge 1 commit into from

Conversation

SkiAn2007
Copy link

@SkiAn2007 SkiAn2007 commented Jul 25, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fix allows client to communicate with OIDC provider which located out of company perimeter and requires to use proxy server

Does this PR introduce a user-facing change?

NONE

@SkiAn2007
oidc provider behind proxy
16a5716 
This fix allows client to communicate with OIDC provider which located out or company perimeter and requires to use proxy server
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 25, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 25, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @SkiAn2007!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot requested review from fabianvf and yliaog July 25, 2024 07:42
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SkiAn2007
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 25, 2024
@SkiAn2007
Copy link
Author

Facing with issues to run tests locally, is there any tests pipeline on PR?

@SkiAn2007 SkiAn2007 marked this pull request as ready for review July 25, 2024 10:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2024
@roycaihw
Copy link
Member

#2256 (comment) Yes the PR has presubmits. Looks like it was waiting for approval to run. I just triggered the test.

roycaihw
roycaihw reviewed Jul 31, 2024
View reviewed changes
kubernetes/base/config/kube_config.py
@@ -420,7 +420,7 @@ def _load_oid_token(self, provider):
return self.token

def _refresh_oidc(self, provider):
config = Configuration()
config = Configuration().get_default_copy()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we unit test this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who do you mean? As far as I see all tests are passed.
I checked this change locally, and it works.

@SkiAn2007 SkiAn2007 requested a review from roycaihw August 2, 2024 06:26
@roycaihw
Copy link
Member

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2024
@SkiAn2007
Copy link
Author

@roycaihw @yliaog @fabianvf

What's the next step in the review? What is required on my part?

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2024
@yliaog
Copy link
Contributor

yliaog commented Nov 13, 2024

i think @roycaihw was asking if you could add a new unittest case for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf Awaiting requested review from fabianvf

@yliaog yliaog Awaiting requested review from yliaog

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@roycaihw roycaihw

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SkiAn2007 @k8s-ci-robot @roycaihw @k8s-triage-robot @yliaog