-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returns the created k8s objects in create_from_{dict,yaml}. #1262
Returns the created k8s objects in create_from_{dict,yaml}. #1262
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @sighingnow! |
Signed-off-by: Tao He <[email protected]>
8f16d0b
to
9e534d0
Compare
@k8s-ci-robot I signed it! |
please fix the travis-ci |
Signed-off-by: Tao He <[email protected]>
@yliaog Fixed. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sighingnow, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It would be much convenient if the created kubernetes API objects could be returned, especially when the source is opequa yaml file.
Seems that there's no reason for not returning those results.