-
Notifications
You must be signed in to change notification settings - Fork 184
feat: merging kubeconfig files #94
feat: merging kubeconfig files #94
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 92.04% 92.64% +0.59%
==========================================
Files 13 13
Lines 1182 1264 +82
==========================================
+ Hits 1088 1171 +83
+ Misses 94 93 -1
Continue to review full report at Codecov.
|
d7f8138
to
fea09d4
Compare
@roycaihw could you take a look? |
@roycaihw Have you had time to look into this? |
8d4c760
to
6f50d7d
Compare
674a42e
to
bf30bb8
Compare
bf30bb8
to
328b2d1
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw, tomplus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@roycaihw Thank you! |
I'm trying to add support for multiple kubeconfig file. I prepared an additional class which merges configs and produces ConfigNode which can be passed directly to KubeConfigLoader. KubeConfigLoader and other public methods are backward compatible. I had to extend the ConfigNode by adding path to source kubeconfig too, because paths to certificates are relative.
Please let me know what you think.
Related issue: #62