This repository has been archived by the owner on Mar 13, 2022. It is now read-only.
Add support for refreshing Azure tokens. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
We use tox to test |
|
Thanks, filed kubernetes-client/python#579 for requirements.txt |
roycaihw
reviewed
Jul 23, 2018
config/kube_config.py
Outdated
| client_id = config['client-id'] | ||
| token_response = context.acquire_token_with_refresh_token( | ||
| refresh_token, client_id, '00000002-0000-0000-c000-000000000000') | ||
|
|
There was a problem hiding this comment.
the CI pycodestyle complains about blank line containing whitespace
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=========================================
- Coverage 93.14% 91.85% -1.3%
=========================================
Files 11 11
Lines 977 994 +17
=========================================
+ Hits 910 913 +3
- Misses 67 81 +14
Continue to review full report at Codecov.
|
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roycaihw
This requires an update to the 'requirements.txt' to import the
adallibrary, but it appears that is in a different repo?@roycaihw is there advice for how to add dependencies?
Thanks!