-
Notifications
You must be signed in to change notification settings - Fork 184
fix cfg is none, load kube config error #198
fix cfg is none, load kube config error #198
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @ACXLM! |
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 13 13
Lines 1519 1519
=======================================
Hits 1408 1408
Misses 111 111
Continue to review full report at Codecov.
|
f7a1363
to
b76029c
Compare
Signed-off-by: zhu hui <[email protected]>
b76029c
to
3ff79da
Compare
/assign @roycaihw |
Could you add a unit test for this behavior? Thanks |
since users set to None, load_config() run like the following error:
this PR can fix this error |
2108e57
to
b08556b
Compare
/lgtm |
b08556b
to
5565d32
Compare
@ACXLM: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fixed pycodestyle test failure |
5565d32
to
30d9e2a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ACXLM, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixed
kubernetes/kubernetes#84503 changed the behaviour of kubectl config unset slightly that if no users left in kubeconfig after user run kubectl config unset users., the value of users field in kubeconfig would be set to null rather than [].
since users set to null, kubernetes.config.kube_config.load_kube_config() can't work, this pr set a default empty list to users
Which issue(s) this PR fixes:
Try to fixes
#183
#181