Fixed Watch.unmarshal_event when data is not a JSON-serialized object

[Ark-kun]

Log streaming using Watch was introduced in #93, but the users faced errors when the log line was a single number or an empty string.
This PR fixes those issues.

Fixes kubernetes-client/python#982
Fixes kubernetes-client/python#983

[k8s-ci-robot]

Welcome @Ark-kun!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[codecov-io]

Codecov Report

Merging #171 into master will decrease coverage by 0.06%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   93.41%   93.35%   -0.07%     
==========================================
  Files          13       13              
  Lines        1398     1400       +2     
==========================================
+ Hits         1306     1307       +1     
- Misses         92       93       +1

Impacted Files	Coverage Δ
watch/watch.py	98.82% <50%> (-1.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b65461...f11587d. Read the comment docs.

[roycaihw]

/cc @jiahuif

[k8s-ci-robot]

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: jiahuif.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jiahuif

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jiahuif]

As discussed here kubernetes-client/python#982 (comment)

If the object has a field named "object", the fix would not work. We should not rely on one of the field to determine the type.

[Ark-kun]

If the object has a field named "object", the fix would not work. We should not rely on one of the field to determine the type.

Unfortunately, dictionaries are duck-typed by design.
The code in question insists on accessing the 'object' key.
Without the fix, the code is randomly broken in large number of cases.

Can you please suggest another way to fix the common path?

[scottilee]

@jiahuif any update for @Ark-kun ?

[jiahuif]

@scottilee See kubernetes-client/python#1032

[kvalev]

Log streaming using Watch was introduced in #93, but the users faced errors when the log line was a single number or an empty string.

Also when the log line represents an empty array [], like we just had.

[roycaihw]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment