Add params to publish-gen-image.sh #3716
Merged
+12
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it convenient to publish a copy of crd-model-gen to a private container registry.
Refactor client-java-contrib/publish-gen-image.sh to accept parameters via environment variables. At the same time, refactor scripts/publish-crd-model-gen-image.sh to remove duplicated logic. This also serves as an example of how to invoke publish-gen-image.sh.
In case there are existing workflows that depend on these two scripts, I have not renamed either of them, and they have the same behavior when no environment variables are provided.