Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump spotless-maven-plugin from 2.30.0 to 2.34.0 #2579

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 28, 2023

Bumps spotless-maven-plugin from 2.30.0 to 2.34.0.

Changelog

Sourced from spotless-maven-plugin's changelog.

[2.34.0] - 2023-01-26

Added

  • Formatter now has a field public static final File NO_FILE_SENTINEL which can be used to pass string content to a Formatter or FormatterStep when there is no actual File to format. (#1525)

[2.33.0] - 2023-01-26

Added

  • ProcessRunner has added some convenience methods so it can be used for maven testing. (#1496)
  • ProcessRunner allows to limit captured output to a certain number of bytes. (#1511)
  • ProcessRunner is now capable of handling long-running tasks where waiting for exit is delegated to the caller. (#1511)
  • Allow to specify node executable for node-based formatters using nodeExecutable parameter (#1500)

Fixed

  • The default list of type annotations used by formatAnnotations has had 8 more annotations from the Checker Framework added #1494

Changes

  • POTENTIALLY BREAKING Bump minimum JRE from 8 to 11, next release likely to bump bytecode to Java 11 (#1514 part 1 of #1337)
  • Rename YamlJacksonStep into JacksonYamlStep while normalizing Jackson usage (#1492)
  • Convert gson integration to use a compile-only source set (#1510).
  • ** POTENTIALLY BREAKING** Removed support for KtLint 0.3x and 0.45.2 (#1475)
    • KtLint does not maintain a stable API - before this PR, we supported every breaking change in the API since 2019.
    • From now on, we will support no more than 2 breaking changes at a time.
  • NpmFormatterStepStateBase delays npm install call until the formatter is first used. This enables better integration with gradle-node-plugin. (#1522)
  • Bump default ktlint version to latest 0.48.1 -> 0.48.2 (#1529)
  • Bump default scalafmt version to latest 3.6.1 -> 3.7.1 (#1529)

[2.32.0] - 2023-01-13

Added

  • Add option editorConfigFile for ktLint #142
    • POTENTIALLY BREAKING ktlint step now modifies license headers. Make sure to put licenseHeader after ktlint.
  • Added skipLinesMatching option to licenseHeader to support formats where license header cannot be immediately added to the top of the file (e.g. xml, sh). (#1441).
  • Add YAML support through Jackson (#1478)
  • Added support for npm-based ESLint-formatter for javascript and typescript (#1453)
  • Better suggested messages when user's default is set by JVM limitation. (#995)

Fixed

  • Support ktlint 0.48+ new rule disabling syntax (#1456) fixes (#1444)
  • Fix subgroups leading catch all matcher.

Changes

  • Bump default version for prettier from 2.0.5 to 2.8.1 (#1453)
  • Bump the dev version of Gradle from 7.5.1 to 7.6 (#1409)
    • We also removed the no-longer-required dependency org.codehaus.groovy:groovy-xml
  • Breaking changes to Spotless' internal testing infrastructure testlib (#1443)
    • ResourceHarness no longer has any duplicated functionality which was also present in StepHarness
    • StepHarness now operates on Formatter rather than a FormatterStep
    • StepHarnessWithFile now takes a ResourceHarness in its constructor to handle the file manipulation parts
    • Standardized that we test exception messages, not types, which will ease the transition to linting later on
    • Bump default ktlint version to latest 0.47.1 -> 0.48.1 (#1456)
  • Switch our publishing infrastructure from CircleCI to GitHub Actions (#1462).
    • Help wanted for moving our tests too (#1472)

[2.31.1] - 2023-01-02

Fixed

... (truncated)

Commits
  • 599e1e4 Published lib/2.34.0
  • 47985cd Add Formatter.NO_FILE_SENTINEL (#1525)
  • 1f78aff Update changelog.
  • ad78bc6 Merge branch 'main' into FromFileToPath
  • 9adce64 Fix javadoc.
  • 5bef415 Published maven/2.31.0
  • 07a57ff Rename the sentinel and move it to Formatter.
  • f1cfc61 Published gradle/6.14.0
  • 2995371 So we have to run the workflow on the release branch, and we need to pull...
  • 2aa7f51 Another shot at fixing our publish workflow.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.30.0 to 2.34.0.
- [Release notes](https://github.com/diffplug/spotless/releases)
- [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md)
- [Commits](diffplug/spotless@lib/2.30.0...lib/2.34.0)

---
updated-dependencies:
- dependency-name: com.diffplug.spotless:spotless-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brendandburns
Copy link
Contributor

Spotless has moved to require Java 11 (diffplug/spotless#1337)

@yue9944882 wdyt? Should we just move the github action forward to use Java 11 instead of Java 8?

I feel like that is probably the right answer.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 14, 2023

Superseded by #2594.

@dependabot dependabot bot closed this Mar 14, 2023
@dependabot dependabot bot deleted the dependabot/maven/com.diffplug.spotless-spotless-maven-plugin-2.34.0 branch March 14, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file java Pull requests that update Java code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants