Skip to content

Commit

Permalink
feat(sdk): Use google.protobuf.Value in v2 for passing parameters. (#…
Browse files Browse the repository at this point in the history
…6804)

* Use google.protobuf.Value in v2 for passing parameters.

* retest samples.

* Fix tests.

* Update release, more cleanup.

* Use github.com/kubeflow/pipelines/api from same repo.

* Run go mod tidy

* chore: go mod tidy

* fix v2 compile error and clean up unused code

* pr comments.

* update goldens

* Fix metadata recording.

* Update kfp mlmd client.

* fix test again

* another try.

* chore: migrate v2 DAG driver input parameters to protobuf.Value + small refactorings

* fix v2 launcher + clean up

* fix a compile error

* fix a few more tests

* fix number parsing

* clean up

* disable cache_v2 test.

Co-authored-by: Yuan Gong <[email protected]>
  • Loading branch information
neuromage and Bobgy authored Oct 28, 2021
1 parent 0c40154 commit 0be57c3
Show file tree
Hide file tree
Showing 60 changed files with 1,524 additions and 1,372 deletions.
5 changes: 4 additions & 1 deletion api/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,7 @@ module github.com/kubeflow/pipelines/api

go 1.16

require google.golang.org/protobuf v1.27.1
require (
google.golang.org/genproto v0.0.0-20211026145609-4688e4c4e024
google.golang.org/protobuf v1.27.1
)
116 changes: 115 additions & 1 deletion api/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion api/v2alpha1/cache_key.proto
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ syntax = "proto3";
option go_package = "github.com/kubeflow/pipelines/api/v2alpha1/go/cachekey";
package ml_pipelines;

import "google/protobuf/any.proto";
// import "google/protobuf/any.proto";
import "google/protobuf/struct.proto";
import "pipeline_spec.proto";

message CacheKey {
Expand All @@ -26,6 +27,7 @@ message CacheKey {
map<string, RuntimeArtifact> outputArtifactsSpec = 3;
map<string, string> outputParametersSpec=4;
ContainerSpec containerSpec=5;
map<string, google.protobuf.Value> input_parameter_values = 6;
}

message ContainerSpec {
Expand Down
Loading

0 comments on commit 0be57c3

Please sign in to comment.