Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use also different K8s versions for E2E testing in GHA #659

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Dec 16, 2024

proposal for #614

Description

please note

Note All include combinations are processed after exclude

from: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#excluding-matrix-configurations

How Has This Been Tested?

see #659 (comment)

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tarilabs. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Matteo Mortari <[email protected]>
@tarilabs tarilabs force-pushed the tarilabs-20241216-matrixK8sVersionE2E branch from 3d0bda2 to 5cddf56 Compare December 16, 2024 18:14
Signed-off-by: Matteo Mortari <[email protected]>
@tarilabs tarilabs force-pushed the tarilabs-20241216-matrixK8sVersionE2E branch from 73873cd to 7bf5582 Compare December 16, 2024 18:54
Revert "demo on PR how it would look on main merges"

This reverts commit ecd8778.

Signed-off-by: Matteo Mortari <[email protected]>
@tarilabs
Copy link
Member Author

with ecd8778

demo-ing on PR how it would look like on main merges:
image

with f41b2cd

showing how it is effective on PR:

image

@Al-Pragliola @lampajr wdyt?

@tarilabs tarilabs marked this pull request as ready for review December 16, 2024 21:36
@google-oss-prow google-oss-prow bot requested a review from rareddy December 16, 2024 21:36
@tarilabs tarilabs linked an issue Dec 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: use matrix of k8s versions with KinD e2e testing
1 participant