Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow continously used caches to be scaled to 2 copies #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Allow continously used caches to be scaled to 2 copies #153

wants to merge 1 commit into from
+4 −1

Conversation

haiminh2001
Copy link

Motivation

  • The earlierUseIteration (i1) is updated when i1 are not in range, including two cases: i1 is smaller than the lower bound (40m ago) and larger than the upper bound (7m ago).
  • Therefore, if a model is used continously, the earlierUseIteration (i1) will always be larger than the upper bound and will never be in range. To be scaled to 2 copies, the model has to be used once, wait for 7 minutes WITHOUT ANY other usage, if any other usage appear, it will interrupt (update the earlierUseIteration to the lastUsedIteration).

Modifications

  • Only update the earlierUseIteration if i1 smaller than the lower bound, not when i1 larger than the upper bound.

Results:

  • A model that is continuously used will be abled to two copies, maintain the HA of that model.

@haiminh2001
fix: Allow continously used caches to be scaled to 2 copies
1d6ed06 
Motivation:

- The earlierUseIteration (i1) is updated when i1 are not in range, including two cases: i1 is smaller than the lower bound (40m ago) and larger than the upper bound (7m ago).
- Therefore, if a model is used continously, the earlierUseIteration (i1) will always be larger than the upper bound and will never be in range. To be scaled to 2 copies, the model has to be used once, wait for 7 minutes WITHOUT ANY other usage, if any other usage appear, it will interrupt (update the earlierUseIteration to the lastUsedIteration).

Modifications:

- Only update the earlierUseIteration if i1 smaller than the lower bound, not when i1 larger than the upper bound.

Results:
- A model that is continously used will be abled to two copies, maintain the HA of that model.

Signed-off-by: haiminh2001 <[email protected]>
@haiminh2001 haiminh2001 mentioned this pull request Nov 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@haiminh2001