-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add animated emoji support #450
base: main
Are you sure you want to change the base?
Conversation
TheOneWithTheBraid
commented
Jul 16, 2023
- implement animated emoji support in both HTML and Linkify message type
- fix some missing font glyphs
- trim message input
51bae14
to
65b1628
Compare
Can you clean up the commit history and make sure that every commit does only one thing? For example why do you change |
65b1628
to
b0bd0d0
Compare
Yeah, sorry, the commit history completely broke from rebasing and migrating onto the new upsream. These commits fix what's stated in the pubspec.yaml, which is at least about the noto font directly related to emojis. Since it'd feel weird to only fix it for one of the two font families, I fixedit for roboto too - though it's actually not related to the emoji support. Sorry again, the commit history was re-written many times, since also the upstream commit history was re-written and during cherry-picking in the commits onto the new upstream history, most of the commit messages were somehow breaking again. If you want, I can take the time to restore them, but that'd be quite lots of manual work. |
|
4f82cf0
to
9debf2b
Compare
91a9f56
to
5f65044
Compare
5f65044
to
d038e6c
Compare
d038e6c
to
d2bbd15
Compare
Poke @krille-chan : Do you have any update on this Pull Request ? |
d2bbd15
to
e00874b
Compare
e00874b
to
733c7a0
Compare
a32e654
to
8a3f886
Compare
As long as it does bring so much more stuff to load for the initial start of the web app I unfortunately see no way to merge this. :-/ It could be possible by not shipping this in the web-version if it works to fallback to normal emojis there |
What do you mean by this ? There are no new assets added or changed. Do you have concerns about loading the |
- implement animated emoji support in both HTML and Linkify message type - fix some missing font glyphs - trim message input Signed-off-by: The one with the braid <[email protected]>
8a3f886
to
dc8d77b
Compare
Any updates on this? Animated emojis would be nice |
just had no time for this yet. My concerns are that this delays the start-up on web for too long or loads too much from google servers (while the web app already loads emojis from google servers unfortunately) |
Yes, that was exactly the issue. Basically we'd need to decide : Do we want super slow startup and no stuff from google servers (initial load +5MB), slow startup and only fallback glyphs from google servers (+0.3MB startup) or everything from Google servers and fast startup. Either options seems like a regression. Though I actually removed all handling of that case into the #451 so that we don't need to find a solution for this issue before merging this. |