Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Error Widget #828

Closed
XSpielinbox opened this issue Jan 20, 2024 · 10 comments
Closed

[BUG]: Error Widget #828

XSpielinbox opened this issue Jan 20, 2024 · 10 comments
Labels
stale The item is going to be closed soon because of inactivity

Comments

@XSpielinbox
Copy link

  • Operating system: android
  • Version: 1.17.0

Exception

Null check operator used on a null value

StackTrace

#0 SelectableRegionState.startGlyphHeight (package:flutter/src/widgets/selectable_region.dart:1211)
#1 SelectableRegionState.contextMenuAnchors (package:flutter/src/widgets/selectable_region.dart:1093)
#2 new AdaptiveTextSelectionToolbar.selectableRegion (package:flutter/src/material/adaptive_text_selection_toolbar.dart:177)
#3 SelectionArea._defaultContextMenuBuilder (package:flutter/src/material/selection_area.dart:96)
#4 SelectableRegionState._onAnyDragEnd. (package:flutter/src/widgets/selectable_region.dart:694)
#5 SelectionOverlay.showToolbar. (package:flutter/src/widgets/text_selection.dart:1401)
#6 ContextMenuController.show. (package:flutter/src/widgets/context_menu_controller.dart:65)
#7 _OverlayEntryWidgetState.build (package:flutter/src/widgets/overlay.dart:356)
#8 StatefulElement.build (package:flutter/src/widgets/framework.dart:5583)
#9 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5471)
#10 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5634)
#11 Element.rebuild (package:flutter/src/widgets/framework.dart:5187)
#12 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2895)
#13 WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:984)
#14 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:457)
#15 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1325)
#16 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1255)
#17 SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:1113)
#18 _invoke (dart:ui/hooks.dart:312)
#19 PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:383)
#20 _drawFrame (dart:ui/hooks.dart:283)

@XSpielinbox
Copy link
Author

I got this error while scrolling through a chat, probably at viewing some picture.
I don't know for sure.
I received quite some errors on Fluffychat (Flatpak on Fedora Linux 39) as well, but it was always to long for a bug-report. E. g. it seems to be unable to show code snippets: whenever I open a chat with them a error is shown (unfortunately I cannot copy it), but it displays well as far as I can tell, except very long snippets. They just show like this:
Screenshot from 2024-01-20 10-20-49

@krille-chan
Copy link
Owner

Please add some steps to reproduce this or maybe an example source of an event content. Otherwise I cannot do anything I guess

@krille-chan krille-chan added the stale The item is going to be closed soon because of inactivity label Jan 20, 2024
@XSpielinbox
Copy link
Author

The Decrypted event source of the message that produces above rendering error:

  "room_id": "!k[...]y:t[...]e",
  "type": "m.room.message",
  "content": {
    "msgtype": "m.text",
    "body": "```\n[...] ~> ssh [...]\nThe authenticity of host '[...]' can't be established.\nED25519 key fingerprint is SHA256:h[...]s.\nThis key is not known by any other names\nAre you sure you want to continue connecting (yes/no/[fingerprint])? yes\nWarning: Permanently added '[...]' (ED25519) to the list of known hosts.\n[...]'s password:\nWelcome to Ubuntu 20.04.6 LTS (GNU/Linux 5.4.0-169-generic x86_64)\n\n * Documentation:  https://help.ubuntu.com\n * Management:     https://landscape.canonical.com\n * Support:        https://ubuntu.com/advantage\n\nExpanded Security Maintenance for Applications is not enabled.\n\n1 update can be applied immediately.\nTo see these additional updates run: apt list --upgradable\n\n71 additional security updates can be applied with ESM Apps.\nLearn more about enabling ESM Apps service at https://ubuntu.com/esm\n\n\n1 updates could not be installed automatically. For more details,\nsee /var/log/unattended-upgrades/unattended-upgrades.log\n[...]:~$\n```",
    "format": "org.matrix.custom.html",
    "formatted_body": "<pre><code>[...] ~&gt; ssh [...]\nThe authenticity of host '[...]' can't be established.\nED25519 key fingerprint is SHA256:h[...]s.\nThis key is not known by any other names\nAre you sure you want to continue connecting (yes/no/[fingerprint])? yes\nWarning: Permanently added '[...]' (ED25519) to the list of known hosts.\n[...]'s password:\nWelcome to Ubuntu 20.04.6 LTS (GNU/Linux 5.4.0-169-generic x86_64)\n\n * Documentation:  https://help.ubuntu.com\n * Management:     https://landscape.canonical.com\n * Support:        https://ubuntu.com/advantage\n\nExpanded Security Maintenance for Applications is not enabled.\n\n1 update can be applied immediately.\nTo see these additional updates run: apt list --upgradable\n\n71 additional security updates can be applied with ESM Apps.\nLearn more about enabling ESM Apps service at https://ubuntu.com/esm\n\n\n1 updates could not be installed automatically. For more details,\nsee /var/log/unattended-upgrades/unattended-upgrades.log\n[...]:~$\n</code></pre>\n",
    "m.mentions": {}
  }
}

Whenever I open the chat with this message on Linux (does not have to be on screen, but is one of the last 10 messages and therefore probably loaded), I immediately get an error.
On mobile when opening this chat it does not immediately show the error, only when I scroll up to the message. Note that this is pretty much the same error as on Linux and to long for GitHub.

The error in #828 (comment) I got shortly after opening a different group chat - I have no clue what caused that and could not find a way to reproduce it.

@github-actions github-actions bot removed the stale The item is going to be closed soon because of inactivity label Jan 21, 2024
@krille-chan
Copy link
Owner

Hm can you try again v1.17.2? I have sent this message as raw json into a room and it worked fine for me:

grafik

@XSpielinbox
Copy link
Author

I will try it as soon as it is available on F-Droid and via Flathub.

@XSpielinbox
Copy link
Author

Yes, at least on Android the rendering bug is fixed in 1.17.1.

@LFd3v
Copy link

LFd3v commented Feb 9, 2024

It looks like that this issue was fixed as of v1.17.3, so it can be closed?

Copy link

github-actions bot commented Aug 5, 2024

This issue is stale because it has been open for 120 days with no activity.

@github-actions github-actions bot added the stale The item is going to be closed soon because of inactivity label Aug 5, 2024
@LFd3v
Copy link

LFd3v commented Aug 5, 2024

Another issue that can be closed as of now, it seems.

@XSpielinbox
Copy link
Author

I apologize for not answering. It took a while until the new version was available on Flathub and the I completely forgot about it.
Yes, indeed as this seems to be fixed at least in 1.21.2 on Linux Desktop as well, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The item is going to be closed soon because of inactivity
Projects
None yet
Development

No branches or pull requests

3 participants