Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker_container): only wait when healthcheck defined #641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(docker_container): only wait when healthcheck defined #641

wants to merge 1 commit into from

Conversation

FalcoSuessgott
Copy link

@FalcoSuessgott FalcoSuessgott commented Aug 16, 2024 •
edited
Loading

fixes #569

perhaps it makes sense to move wait and wait_timeout attribute into healthcheck block, to make the corelation more obvious?

@FalcoSuessgott FalcoSuessgott marked this pull request as draft August 16, 2024 03:35
@FalcoSuessgott FalcoSuessgott marked this pull request as ready for review August 16, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin crashes when using wait=true with no healthcheck command
1 participant
@FalcoSuessgott