feat(src): Enable buildkit when client has support. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovider-docker into buildkit_support
Did not do really anything
The used image names in the two subtests must be different.
suzuki-shunsuke
requested changes
Jun 23, 2022
suzuki-shunsuke
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first basic PR to see if buildkit support works.
The docker client is bundled within the provider, so it should support buildkit out of the box. For security reasons I still implemented a check for the correct version.
This will close #265
In addition to enabling BuildKit support this also updates some of the used docker image to be able to run the tests on ARM64 Macs :)