Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rewriting tar header fields (#192) #198

Merged
merged 2 commits into from
May 21, 2021
Merged

fix: rewriting tar header fields (#192) #198

merged 2 commits into from
May 21, 2021

Conversation

dlaburthe
Copy link
Contributor

Fix issue with the docker_registry_image resource as per code archive best practices from https://reproducible-builds.org/.

@dlaburthe
Copy link
Contributor Author

Hello @mavogel ,
I've just managed to test my modifications in a bitbucket pipeline and it works great :)
As we are blocked by this bug, do you think we could expect a release soon ?
Maybe in the 2.11 cycle ?

@suzuki-shunsuke
Copy link
Collaborator

master branch includes some unreleased breaking change, so the next release is not v2.11.1 but v3.

@dlaburthe
Copy link
Contributor Author

ok.
Do you have an eta for the v3 ?

@mavogel mavogel added this to the v3.0.0 milestone May 21, 2021
@mavogel
Copy link
Contributor

mavogel commented May 21, 2021

Hi @dlaburthe we do not have an ETA, but we're working constantly on the v3. You can see the progress there. Feel free to contribute. I'll take your PR in.

Thanks for fixing this bug!

@mavogel mavogel self-requested a review May 21, 2021 13:35
@mavogel mavogel linked an issue May 21, 2021 that may be closed by this pull request
docker_registry_image : Provider produced inconsistent final plan #192
Closed
@mavogel mavogel merged commit 588c621 into kreuzwerker:master May 21, 2021
@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label May 21, 2021
@mavogel
Copy link
Contributor

mavogel commented May 21, 2021

Update @dlaburthe : we will cut a v2.11.1 release later, as there are really only fixes until now

@dlaburthe
Copy link
Contributor Author

Thanks @mavogel !

@mavogel mavogel modified the milestones: v3.0.0, v2.12.0 May 23, 2021
@pwt
Copy link

pwt commented May 4, 2022

This change introduced defect #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavogel mavogel mavogel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working r/registry_image
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.

docker_registry_image : Provider produced inconsistent final plan
4 participants
@dlaburthe @suzuki-shunsuke @mavogel @pwt