Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement parsing of provider build output. #82

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

Junkern
Copy link
Contributor

@Junkern Junkern commented Jul 22, 2022

What does this do / why do we need it?

Some providers use go build -o to place the final binary somewhere different than the usual $GOPATH/bin location. Until now we assumed that every provider binary is placed at the $GOPATH/bin location. This is not the case for https://github.com/russellcardullo/terraform-provider-pingdom

How this PR fixes the problem?

Parse the build output to see if there is a go build -o directive used somewhere.

Check lists

  • Test passed
  • Coding style (indentation, etc)

Which issue(s) does this PR fix?

fixes #81
fixes #2

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2718411651

  • 12 of 25 (48.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 61.937%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/app/install.go 12 25 48.0%
Totals Coverage Status
Change from base Build 2711314397: -0.09%
Covered Lines: 275
Relevant Lines: 444

💛 - Coveralls

@Junkern Junkern merged commit ac1b248 into main Jul 22, 2022
@Junkern Junkern deleted the feat/parse_final_executeable_location branch July 22, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a DEBUG mode Parse name and destination of the final executable
2 participants