-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation: Update chap_tree/summary.md #1555
base: main
Are you sure you want to change the base?
Conversation
I have changed some wording, and for line 37, since I do not know c++, I am not sure whether to use "function" or "method". |
Functions defined in an object in cpp is usually referred as a “method”, this follows the terminology commonly accepted in object-oriented programming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Please consider my comment on the title and also the function terminology.
en/docs/chapter_tree/summary.md
Outdated
@@ -1,26 +1,26 @@ | |||
# Summary | |||
|
|||
### Key review | |||
### Key Highlights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have fixed this title throughout this book so no need to change this
I have updated the file with the changed title, and named back to "method". Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: