Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: Update chap_tree/summary.md #1555

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

steventimes
Copy link
Contributor

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • [*] This PR represents the translation of a single, complete document, or contains only bug fixes.
  • [*] The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:

  • I have thoroughly reviewed the code, focusing on its formatting, comments, indentation, and file headers.
  • I have confirmed that the code execution outputs are consistent with those produced by the reference code (Python or Java).
  • The code is designed to be compatible on standard operating systems, including Windows, macOS, and Ubuntu.

@steventimes
Copy link
Contributor Author

I have changed some wording, and for line 37, since I do not know c++, I am not sure whether to use "function" or "method".

@steventimes steventimes changed the title Update summary.md translation: Update chap_tree/summary.md Nov 12, 2024
@yuelinxin
Copy link
Contributor

Functions defined in an object in cpp is usually referred as a “method”, this follows the terminology commonly accepted in object-oriented programming.

Copy link
Contributor

@yuelinxin yuelinxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please consider my comment on the title and also the function terminology.

@@ -1,26 +1,26 @@
# Summary

### Key review
### Key Highlights
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have fixed this title throughout this book so no need to change this

@steventimes
Copy link
Contributor Author

I have updated the file with the changed title, and named back to "method". Thank you

Copy link
Contributor

@yuelinxin yuelinxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants