Skip to content

Commit

Permalink
fs/9p: Eliminate now unused v9fs_get_inode
Browse files Browse the repository at this point in the history
Now with all inode allocation going through get_from_fid
functions we can remove v9fs_get_inode and reduce us down
to a single inode allocation path.

Signed-off-by: Eric Van Hensbergen <[email protected]>
  • Loading branch information
ericvh committed Jan 26, 2024
1 parent 2dc92e5 commit f61c906
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 32 deletions.
2 changes: 0 additions & 2 deletions fs/9p/v9fs_vfs.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ extern struct kmem_cache *v9fs_inode_cache;

struct inode *v9fs_alloc_inode(struct super_block *sb);
void v9fs_free_inode(struct inode *inode);
struct inode *v9fs_get_inode(struct super_block *sb, umode_t mode,
dev_t rdev);
void v9fs_set_netfs_context(struct inode *inode);
int v9fs_init_inode(struct v9fs_session_info *v9ses,
struct inode *inode, umode_t mode, dev_t rdev);
Expand Down
30 changes: 0 additions & 30 deletions fs/9p/vfs_inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -331,36 +331,6 @@ int v9fs_init_inode(struct v9fs_session_info *v9ses,

}

/**
* v9fs_get_inode - helper function to setup an inode
* @sb: superblock
* @mode: mode to setup inode with
* @rdev: The device numbers to set
*/

struct inode *v9fs_get_inode(struct super_block *sb, umode_t mode, dev_t rdev)
{
int err;
struct inode *inode;
struct v9fs_session_info *v9ses = sb->s_fs_info;

p9_debug(P9_DEBUG_VFS, "super block: %p mode: %ho\n", sb, mode);

inode = new_inode(sb);
if (!inode) {
pr_warn("%s (%d): Problem allocating inode\n",
__func__, task_pid_nr(current));
return ERR_PTR(-ENOMEM);
}
err = v9fs_init_inode(v9ses, inode, mode, rdev);
if (err) {
iput(inode);
return ERR_PTR(err);
}
v9fs_set_netfs_context(inode);
return inode;
}

/**
* v9fs_evict_inode - Remove an inode from the inode cache
* @inode: inode to release
Expand Down

0 comments on commit f61c906

Please sign in to comment.