Skip to content

Commit

Permalink
fs/9p: fix dups even in uncached mode
Browse files Browse the repository at this point in the history
In uncached mode we were still seeing duplicate getattr requests
because of aggressive dropping of inodes.  Inode "freshness" is
guarded by other mechanisms when caches are disabled so this
is unnecessary and increases overhead of almost every operation.

Signed-off-by: Eric Van Hensbergen <[email protected]>
  • Loading branch information
ericvh committed Jan 26, 2024
1 parent 724a084 commit be57855
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions fs/9p/vfs_super.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,21 +244,6 @@ static int v9fs_statfs(struct dentry *dentry, struct kstatfs *buf)
return res;
}

static int v9fs_drop_inode(struct inode *inode)
{
struct v9fs_session_info *v9ses;

v9ses = v9fs_inode2v9ses(inode);
if (v9ses->cache & (CACHE_META|CACHE_LOOSE))
return generic_drop_inode(inode);
/*
* in case of non cached mode always drop the
* inode because we want the inode attribute
* to always match that on the server.
*/
return 1;
}

static int v9fs_write_inode(struct inode *inode,
struct writeback_control *wbc)
{
Expand Down Expand Up @@ -293,7 +278,6 @@ static const struct super_operations v9fs_super_ops_dotl = {
.alloc_inode = v9fs_alloc_inode,
.free_inode = v9fs_free_inode,
.statfs = v9fs_statfs,
.drop_inode = v9fs_drop_inode,
.evict_inode = v9fs_evict_inode,
.show_options = v9fs_show_options,
.umount_begin = v9fs_umount_begin,
Expand Down

0 comments on commit be57855

Please sign in to comment.