Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All GET vars are converted to lowercase #49

Open
adoerler opened this issue Aug 12, 2017 · 2 comments
Open

All GET vars are converted to lowercase #49

adoerler opened this issue Aug 12, 2017 · 2 comments
Milestone

Comments

@adoerler
Copy link

Hi,

if one sets a redirect containing parameter values in uppercase, e.g. a Google Campaign like:
?utm_medium=Èmail&utm_campaign=TEST-Campaign
the values (and parameter names) get converted into lowercase which leads in the case of Google to two different campaign sources.
I'm sure there are other cases where capital letters in parameters or values must be respected as well.

I didn't find an option to control this behavior and in the code it looks like toLower is one of the first actions applied to the redirect path.

What was your intention to do a conversion to lower case anytime and is there a workaround to keep capital letters.

Kind regards and thank you for this great extension
Andreas

@mbrodala
Copy link
Contributor

mbrodala commented Jan 5, 2018

I agree that this should not be done unconditionally but it's still nice to have, e.g. with a case-sensitivity flag per redirect.

@pkracht
Copy link

pkracht commented Jan 11, 2018

Also agree and need this fix as soon as possible... see #60
The URL can be camelcase or whatever containing a upper-lower-case token. For example adword and analytics makers (see https://support.google.com/analytics/answer/2938246?hl=en)

bmoex added a commit that referenced this issue Aug 3, 2018
The hash is still being lowercased for url lookup

Resolves: #49
Based on: #60
@bmoex bmoex added this to the 4.0.0 milestone Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants