Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#26: Update nickname ABI and correctly resolve nickname #27

Merged
merged 1 commit into from
Dec 3, 2024
Merged

#26: Update nickname ABI and correctly resolve nickname #27

merged 1 commit into from
Dec 3, 2024

Conversation

mvandeberg
Copy link
Member

Resolves #26

Brief description

Fixes nickname resolution

Checklist

  • I have built this pull request locally
  • I have ran the unit tests locally
  • I have manually tested this pull request
  • I have reviewed my pull request
  • I have added any relevant tests

Demonstration

Old:

❯ curl http://localhost:3000/v1/contract/@lock.koincity.com/abi 
{"error":"unknown error"}

Fixed:

❯ curl http://localhost:3001/v1/contract/@lock.koincity.com/abi
{"contract_id":"1FT1D2jLKeeEFcfG5Zo7WKfYNHH9MMeK5N","abi":{...}}

@mvandeberg mvandeberg requested a review from sgerbino December 3, 2024 16:36
@sgerbino sgerbino merged commit 74e4c6e into master Dec 3, 2024
2 checks passed
@sgerbino sgerbino deleted the 26-name-resolution branch December 3, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgerbino sgerbino sgerbino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Nicknames resolve to owner, not resolved address
2 participants
@mvandeberg @sgerbino