Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Implement Dockerfile #170

Open
1 task done
theoreticalbts opened this issue Nov 21, 2022 · 1 comment
Open
1 task done

[FEATURE]: Implement Dockerfile #170

theoreticalbts opened this issue Nov 21, 2022 · 1 comment
Labels
enhancement New feature or request task

Comments

@theoreticalbts
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

New feature

For development, I want a simple way to locally modify protobuf definitions and build all targets.

Currently, the codegen scripts are very Travis-specific. Running this manually is non-trivial, it involves a large number of moving parts:

  • A specific GO_VERSION is installed from gimme (Travis-specific)
  • PROTOBUF_VERSION is installed by direct tarball download
  • protoc-gen-go is installed (unpinned, latest) with go get
  • EmbeddedProto is installed from a Koinos-maintained fork with git clone
  • NVM is installed with curl | bash

There should be a Dockerfile that will:

  • Build in a separate build directory (a source dir mounted to the Docker container shouldn't be polluted with build outputs)
  • Not attempt to push to a remote repo (this is Travis's responsibility)

Anything else?

No response

@theoreticalbts theoreticalbts added the enhancement New feature or request label Nov 21, 2022
theoreticalbts added a commit to theoreticalbts/koinos-proto that referenced this issue Nov 21, 2022
@koinos-ci
Copy link

This issue is stale because it has been open for 30 days with no activity.

@mvandeberg mvandeberg added task and removed stale labels Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request task
Projects
None yet
Development

No branches or pull requests

3 participants