Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIME type "manifest" added. #679

Open
wants to merge 1 commit into
base: 3.3/develop
Choose a base branch
from
Open

Conversation

saruman
Copy link
Contributor

@saruman saruman commented Apr 20, 2016

No description provided.

@rjd22
Copy link

rjd22 commented Apr 20, 2016

👍 @enov do you also approve?

@rjd22
Copy link

rjd22 commented Apr 20, 2016

@enov I think in this case @saruman is trying to fix a problem that he is having. Adding the spec MIME types would be okay outside this PR when someone else needs those, no?

@enov
Copy link
Contributor

enov commented Apr 20, 2016

Adding the spec MIME types would be okay outside this PR when someone else needs those, no?

You mean if the user adds it to config/mimes.php in the application folder? Yea, if I understood your question, that would be OK.

@saruman
Copy link
Contributor Author

saruman commented Apr 21, 2016

This will be available in 3.4?

@enov
Copy link
Contributor

enov commented Apr 21, 2016

This will be available in 3.4?

This will be available in 3.3 if #682 is merged, but using .appcache file extension. If you need to use .manifest extension, you need to extend the config list of MIME types in your application directory as @rjd22 suggested.

Thank you @saruman @rjd22

@rjd22
Copy link

rjd22 commented Apr 22, 2016

@enov would it be wrong to add both? Maybe just add both for the sake of being complete.

@enov
Copy link
Contributor

enov commented Apr 22, 2016

@rjd22 not sure if that's a good idea. They have specifically changed the suggested extension for reasons related to Microsoft's use of the extension, see below:

whatwg/html@b3e6c24

The only trusted source that I could find, that still suggest .manifest extension is Safari's documentation:

https://developer.apple.com/library/iad/documentation/iPhone/Conceptual/SafariJSDatabaseGuide/OfflineApplicationCache/OfflineApplicationCache.html#//apple_ref/doc/uid/TP40007256-CH7-SW2

It says:

For most web servers, the filename must end in .manifest.

But that does not mean Safari, the browser itself, requires .manifest extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants