fix: uid for drops #9956
fix: uid for drops #9956
Conversation
…tion refactor(PaidGenerative.vue): remove unused code and simplify mintNft function refactor(useDropMassMint.ts): comment out unused code and refactor allocateItems function feat(fxart.ts): add updateMetadata function fix(randomize.ts): increase length parameter in uidMathDate function
…temsGrid refactor: update minting process in PaidGenerative.vue to store NFT metadata on-chain fix: adjust useNft to accept displaySn parameter for controlling display of serial number refactor: update useDropMassMint to include NFT metadata in updateMetadata call fix: adjust useExperiments to rename uid to flagUid refactor: update useNftMetadata to accept displaySn parameter for controlling display of serial number fix: change BASE_URL in fxart service to localhost for local testing refactor: update updateMetadata in fxart service to accept new parameters for updating metadata
fix(PaidGenerative.vue): modify args mapping and reverse order if more than one feat(PaidGenerative.vue): implement mintedNfts array and metadata fetching feat(PaidGenerative.vue): uncomment mintingSession value assignment and subscribeForNftsWithMetadata call refactor(useDrops.ts): modify useDropStatus to accept drop parameter and fetch collection stats fix(useDropMassMint.ts): resolve promise with result directly refactor(useDropMassMintPreview.ts): change name assignment in getPreviewItemsToMintedNfts feat(fxart.ts): add metadata field to DoResult type fix(fxart.ts): change api method to 'get' in updateMetadata function
…ents fix(PaidGenerative.vue): add error handling for metadata fetch feat(MintOverview.vue): add hide-collection attribute to toMintNft component feat(ConfirmPurchaseItemRow.vue): add hideCollection prop and adjust layout fix(useGalleryItem.ts): sanitize IPFS URL for nftImage value
…actual values fix(PaidGenerative.vue): reduce retry count from 20 to 12 and change error logging level from error to warn fix(useDropMassMint.ts): rename 'sn' property to 'nft' in updateMetadata function call feat(fxart.ts): update BASE_URL based on window location host fix(fxart.ts): rename 'sn' property to 'nft' and update endpoint path in updateMetadata function
refactor(ItemsGrid.vue): remove unused flagUid experiment feat(ItemsGrid.vue): add condition to display serial number only for NFTs with id less than 4 digits
…ed 'length' set feat(crypto.spec.ts): add comment about uidCrypto() or uidMath() for more than 1k concurrent users
…mmented mintingSession from useDropMassMint.ts
fix: adjust flagUid condition to include '/ahk/' path only chore: add console log to monitor route changes in useExperiments.ts
refactor(transactionMintDrop.ts): update execMintDrop function to use new hooks and storeToRefs feat(transactionMintDrop.ts): add nftsMetadata computed property refactor(transactionMintDrop.ts): update args mapping and transaction execution within flagUid conditional block
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Hi team @prury @kodadot/internal-dev, feel free to test this PR. Let me know what your concerns are. Make sure to test it only on ahk paid-drop. Changes:NFT IDsThe significant change is that nft now has ten length ID SN on Metadatain the last step, metadata will be set to our fxart worker: https://fxart-beta.kodadot.workers.dev/metadata/v1/json?chain=ahk&collection=403&nft=2404222150&metadata=ipfs:%2F%2Fbafybeiagizkxnmsovz3xczaejzbjslgudgzz4gpktki6zoo3qptuknwx64%2F0.json How sn works: extend ipfs metadata, and override name with No dependencies to
|
|
This is multi kill, looking forward, amazing work! 💪
|
|
@preschian it seems that in this PR, sn is no longer showing inside collections https://deploy-preview-9956--koda-canary.netlify.app/ahp/collection/112 |
on it, I just realized that grid list on drops page and collection page was use different setting should be show up like this https://deploy-preview-9956--koda-canary.netlify.app/ahp/drops/convergente |
|
ok was finally able to mint on the purple pills using this PR https://deploy-preview-9956--koda-canary.netlify.app/ahk/gallery/406-2404717144
|
yes, it will affect all paid drops on ahk and ahp. steps before deployment to production:
lmk if done testing, I will remove the flag and deploy the PR on fxart |
prury
added
the
S-works-for-me-✅
perfect, good to go for me, better to merge to canary today so i can detected any other thing before tomorrows drop |
…nd related testing code
…th function fix(randomize.ts): replace uidMath with uidCrypto in uidMathDate function
updated 👍🏻 |
|
@kodadot/internal-dev can we get some ❤️ reviews? |
Co-authored-by: Jarsen <[email protected]>
|
Code Climate has analyzed commit d03cd0a and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
|
oke it's on canary too. cc @preschian maybe we can try swap to Filebase? since we are it paying anyways iirc
|
|
Once got #9974 resolved I'm gonna merge this and then probably release. |
|
tested single cc @exezbcz |
|
Thanks! |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
|
My fav video Screen.Recording.2024-04-04.at.13.13.19.mov |
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Context here: https://github.com/kodadot/private-workers/issues/99
Did your issue had any of the "$" label on it?