Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Auto teleport - user should have at least 1.5 DOT #9953

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Apr 1, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

based on

CleanShot 2024-04-01 at 13 14 01@2x

CleanShot 2024-04-01 at 13 28 41@2x

ED is already 1.5 DOT, disabled the feature that allowed the autotelport of all balance in the case of slashing,

now you can only autotelport any sum above of 1.5

just to make sure tested all the remaining autotelport logic , as far I can see it's working as expected. @prury please test  

Needs QA check

  • @kodadot/qa-guild

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

@hassnian hassnian requested a review from a team as a code owner April 1, 2024 08:27
@hassnian hassnian requested review from vikiival and daiagi and removed request for a team April 1, 2024 08:27
@kodabot
Copy link
Collaborator

kodabot commented Apr 1, 2024

SUCCESS @hassnian PR for issue #9929 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ef0c07a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/660c1fae2b6d2200085c934b
😎 Deploy Preview https://deploy-preview-9953--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury
Copy link
Member

prury commented Apr 1, 2024

nice finding, it was this then that was causing the bug, ty

edit: exez found it first lol

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Apr 1, 2024
@vikiival
Copy link
Member

vikiival commented Apr 2, 2024

If it works let's merge it.

The code you have commented out is unreadable for me, sorry

@hassnian
Copy link
Contributor Author

hassnian commented Apr 2, 2024

The code you have commented out is unreadable for me, sorry

fair enough, can remove it if you want

the entire auto-teleport needs some refactoring to be done #9695

Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codeclimate bot commented Apr 2, 2024

Code Climate has analyzed commit ef0c07a and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury enabled auto-merge April 2, 2024 15:11
@prury
Copy link
Member

prury commented Apr 2, 2024

@vikiival can we get approval?

@prury prury added this pull request to the merge queue Apr 3, 2024
Merged via the queue into kodadot:main with commit f17e5d8 Apr 3, 2024
19 checks passed
@prury prury deleted the issue-9929 branch April 3, 2024 09:09
@prury
Copy link
Member

prury commented Apr 3, 2024

pay 15 usd

@yangwao
Copy link
Member

yangwao commented Apr 3, 2024

😍 Perfect, I’ve sent the payout
💵 $15 @ 8.63 USD/DOT ~ 1.738 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x7d8344caa179a23c93c6faedb9a2de9149e76fbec9c1203ce2fdd822c88da1ed

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 3, 2024
This was referenced Apr 4, 2024
@vikiival vikiival mentioned this pull request Apr 8, 2024
@vikiival vikiival mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto teleport - user should have at least 1.5 DOT
6 participants