Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile V3 smol adjustments #9942

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Profile V3 smol adjustments #9942

merged 4 commits into from
Mar 31, 2024

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Mar 30, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Design

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

Changed stats font size from 20px (text-xl) to 18px (`text-lg')

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@daiagi daiagi requested a review from a team as a code owner March 30, 2024 11:50
@daiagi daiagi requested review from vikiival and hassnian and removed request for a team March 30, 2024 11:50
@kodabot
Copy link
Collaborator

kodabot commented Mar 30, 2024

SUCCESS @daiagi PR for issue #9940 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0f8946c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6609560164659f0008fa37f5
😎 Deploy Preview https://deploy-preview-9942--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daiagi daiagi requested review from Jarsen136 and exezbcz and removed request for vikiival and hassnian March 30, 2024 11:50
@daiagi
Copy link
Contributor Author

daiagi commented Mar 30, 2024

@yangwao

and probably closer to line

what do you mean?

@daiagi daiagi changed the title Profilev3_smol_adjustments Profile V3 smol adjustments Mar 30, 2024
components/profile/ProfileDetailV3.vue Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Mar 31, 2024

Code Climate has analyzed commit 0f8946c and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Mar 31, 2024

what do you mean?

will discuss with exez, I mean it's first shot v3.1 so it's good like this and we will do some cosmetics

Thanks!
pay 30 usd

@yangwao yangwao merged commit 0db3818 into main Mar 31, 2024
17 of 18 checks passed
@yangwao yangwao deleted the profilev3_smol_adjustments branch March 31, 2024 12:25
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Mar 31, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 9.56 USD/DOT ~ 3.138 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0xc476d3d2c730d0cffe943e209051ac1781bb10e43a5998323843f2ab7d7b80ad

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 31, 2024
This was referenced Apr 4, 2024
This was referenced Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile v3 smol adjustments
3 participants