Refactor: `useTransaction` for drop mint #9908

Jarsen136 · 2024-03-28T10:35:47Z

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

Closes useTransaction in Drops #9750

use useTransaction to unify the minting process between paid and holderOf drop.

Did your issue had any of the "$" label on it?

My DOT address: Payout

Screenshot 📸

My fix has changed UI

kodabot · 2024-03-28T10:35:51Z

SUCCESS @Jarsen136 PR for issue #9750 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

netlify · 2024-03-28T10:36:04Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`e44074c`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6609722932d33f000829d124
😎 Deploy Preview	https://deploy-preview-9908--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yangwao · 2024-03-28T10:54:55Z

prury · 2024-03-28T18:13:04Z

Not related with PR:
I'm out of resources to test this:

my purple pills drop only gets nft ids that were already assigned
reflection of the sound(holder of test drop) doesn't seem to be working no more
was able to mint one on monotif test drop, listing button never loaded(Success modal):

daiagi · 2024-03-29T03:44:46Z

composables/transaction/transactionMintDrop.ts

+
+  const args = item.nfts.map((allocatedNft, index) =>
+    api.tx.nfts.mint(item.collectionId, allocatedNft.id, accountId.value, {
+      ownedItem: (item.availableSerialNumbers || [])[index] || null,


(item.availableSerialNumbers || [])[index]

could this error if index is out of bounds?

No error. If out of bounds, it returns undefined and falls back to null finally.

daiagi

code looks clean and straightforward

@prury please verify that minting in all drops types still works

components/collection/drop/PaidGenerative.vue

yangwao · 2024-03-29T10:11:31Z

was able to mint one on monotif test drop, listing button never loaded(Success modal):

This is happening in production iirc from time to time.

prury · 2024-03-29T12:58:52Z

code looks clean and straightforward

@prury please verify that minting in all drops types still works

please check: #9908 (comment)

yangwao · 2024-03-31T12:25:36Z

please check: #9908 (comment)

@Jarsen136 is this still thing?

Jarsen136 · 2024-03-31T12:29:46Z

please check: #9908 (comment)

@Jarsen136 is this still thing?

NO. It means prury has tested and has not found a new bug/issue related to this PR. The issues mentioned above existed before.

I think it's ready to merge.

prury · 2024-03-31T12:37:42Z

please check: #9908 (comment)

@Jarsen136 is this still thing?

Let me provide a better explanation: i could not test this PR because most test drops aren't working properly for me. But the problem is not coming from this PR, is from canary

Jarsen136 · 2024-03-31T12:57:22Z

please check: #9908 (comment)

@Jarsen136 is this still thing?

Let me provide a better explanation: i could not test this PR because most test drops aren't working properly for me. But the problem is not coming from this PR, is from canary

This PR focuses on refactoring and unifying the minting process for both paid and holderOf drops.
I have tested this PR with the paid drop. Could you pick one of the drops and test it? The minting process is still the same as before.

Not related with PR:

my purple pills drop only gets nft ids that were already assigned

We already have this kind of issue. #9765

reflection of the sound(holder of test drop) doesn't seem to be working no more
was able to mint one on monotif test drop, listing button never loaded(Success modal):

Let's raise issues for these bugs as they are from canary.

codeclimate · 2024-03-31T14:25:09Z

Code Climate has analyzed commit e44074c and detected 0 issues on this pull request.

View more on Code Climate.

sonarqubecloud · 2024-03-31T14:26:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

prury · 2024-03-31T15:12:12Z

This PR focuses on refactoring and unifying the minting process for both paid and holderOf drops. I have tested this PR with the paid drop. Could you pick one of the drops and test it? The minting process is still the same as before.

I'm aware of this and I'm not blaming you or this PR, i just want to make clear that while i can test a paid drop, i cannot verify if the holderOf minting works because of problems that exist outside this PR. And yes, an issue for those other problems was opened already.

Another reason that its preventing me from verifying this PR that just appeared is that stuff that i minted its not being reflected on koda, again, issue already opened for this problem, that is outside the scope of this PR.

Feel free to merge the PR, I'm just saying I'm unable to test PR because of external problems

Let's raise issues for these bugs as they are from canary.

done ✔️

yangwao · 2024-04-01T09:45:28Z

Thanks!
pay 50 usd

yangwao · 2024-04-01T09:45:42Z

😍 Perfect, I’ve sent the payout
💵 $50 @ 9.27 USD/DOT ~ 5.394 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x85ffa39445b193c3591c471439aa088c2f4fa1cdd1b7f40f1f571b1f91c92652

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

Jarsen136 added 2 commits March 28, 2024 11:33

refactor: useTransaction for drop mint

6a8e983

refactor: useTransaction for holder of drop mint

88e217b

Jarsen136 requested a review from a team as a code owner March 28, 2024 10:35

Jarsen136 requested review from preschian and removed request for a team March 28, 2024 10:35

Jarsen136 added 2 commits March 28, 2024 11:39

fix: deep scan

1b0c547

Merge branch 'main' into issue-9750

d6ee6cf

prury requested a review from daiagi March 28, 2024 13:36

Merge branch 'main' into issue-9750

0e70532

prury mentioned this pull request Mar 28, 2024

Set up Test drops #9926

Open

daiagi reviewed Mar 29, 2024

View reviewed changes

daiagi approved these changes Mar 29, 2024

View reviewed changes

preschian approved these changes Mar 29, 2024

View reviewed changes

components/collection/drop/PaidGenerative.vue Outdated Show resolved Hide resolved

Jarsen136 added 2 commits March 29, 2024 12:38

chore: maps convert

2bdf392

Merge branch 'main' into issue-9750

6a5acb4

Merge branch 'main' into issue-9750

e44074c

yangwao merged commit deb0205 into kodadot:main Apr 1, 2024
19 checks passed

yangwao added the paid pull-request has been paid label Apr 1, 2024

This was referenced Apr 4, 2024

beta update #9975

Merged

release update #9976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor: `useTransaction` for drop mint #9908

Refactor: `useTransaction` for drop mint #9908

Jarsen136 commented Mar 28, 2024 •

edited

Loading

kodabot commented Mar 28, 2024

netlify bot commented Mar 28, 2024 •

edited

Loading

yangwao commented Mar 28, 2024 •

edited

Loading

prury commented Mar 28, 2024 •

edited

Loading

daiagi Mar 29, 2024

Jarsen136 Mar 29, 2024

daiagi left a comment

yangwao commented Mar 29, 2024

prury commented Mar 29, 2024

yangwao commented Mar 31, 2024

Jarsen136 commented Mar 31, 2024

prury commented Mar 31, 2024

Jarsen136 commented Mar 31, 2024 •

edited

Loading

codeclimate bot commented Mar 31, 2024

sonarqubecloud bot commented Mar 31, 2024

prury commented Mar 31, 2024 •

edited

Loading

yangwao commented Apr 1, 2024

yangwao commented Apr 1, 2024

Refactor: useTransaction for drop mint #9908

Refactor: useTransaction for drop mint #9908

Conversation

Jarsen136 commented Mar 28, 2024 • edited Loading

PR Type

Needs QA check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

kodabot commented Mar 28, 2024

netlify bot commented Mar 28, 2024 • edited Loading

✅ Deploy Preview for koda-canary ready!

yangwao commented Mar 28, 2024 • edited Loading

prury commented Mar 28, 2024 • edited Loading

daiagi Mar 29, 2024

Choose a reason for hiding this comment

Jarsen136 Mar 29, 2024

Choose a reason for hiding this comment

daiagi left a comment

Choose a reason for hiding this comment

yangwao commented Mar 29, 2024

prury commented Mar 29, 2024

yangwao commented Mar 31, 2024

Jarsen136 commented Mar 31, 2024

prury commented Mar 31, 2024

Jarsen136 commented Mar 31, 2024 • edited Loading

codeclimate bot commented Mar 31, 2024

sonarqubecloud bot commented Mar 31, 2024

Quality Gate passed

prury commented Mar 31, 2024 • edited Loading

yangwao commented Apr 1, 2024

yangwao commented Apr 1, 2024

Refactor: `useTransaction` for drop mint #9908

Refactor: `useTransaction` for drop mint #9908

Jarsen136 commented Mar 28, 2024 •

edited

Loading

netlify bot commented Mar 28, 2024 •

edited

Loading

yangwao commented Mar 28, 2024 •

edited

Loading

prury commented Mar 28, 2024 •

edited

Loading

Jarsen136 commented Mar 31, 2024 •

edited

Loading

prury commented Mar 31, 2024 •

edited

Loading